Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2244)

Unified Diff: chrome/browser/shell_integration.cc

Issue 13864015: Move app launcher and chrome apps shortcut strings into the installer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@migrate_app_id_fix
Patch Set: fix linux Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/shell_integration.cc
diff --git a/chrome/browser/shell_integration.cc b/chrome/browser/shell_integration.cc
index e2959045e2beed99a74cdfcc85592e48d0296667..82080877ade29f7926f5ffc7370afe51f46346c9 100644
--- a/chrome/browser/shell_integration.cc
+++ b/chrome/browser/shell_integration.cc
@@ -22,6 +22,12 @@
#include "chromeos/chromeos_switches.h"
#endif
+#if !defined(OS_WIN)
+#include "chrome/common/chrome_version_info.h"
+#include "grit/chromium_strings.h"
+#include "ui/base/l10n/l10n_util.h"
+#endif
+
using content::BrowserThread;
ShellIntegration::DefaultWebClientSetPermission
@@ -39,7 +45,7 @@ ShellIntegration::ShortcutInfo::~ShortcutInfo() {}
ShellIntegration::ShortcutLocations::ShortcutLocations()
: on_desktop(false),
- in_applications_menu(false),
+ applications_menu_location(APP_MENU_LOCATION_NONE),
in_quick_launch_bar(false),
hidden(false) {
}
@@ -109,6 +115,14 @@ CommandLine ShellIntegration::CommandLineArgsForLauncher(
}
#if !defined(OS_WIN)
+
+base::string16 ShellIntegration::GetAppShortcutsSubdirName() {
+ chrome::VersionInfo::Channel channel = chrome::VersionInfo::GetChannel();
gab 2013/10/17 15:13:31 I think this can be inlined below and still fit on
calamity 2013/11/20 05:43:30 Done.
+ if (channel == chrome::VersionInfo::CHANNEL_CANARY)
+ return l10n_util::GetStringUTF16(IDS_APP_SHORTCUTS_SUBDIR_NAME_CANARY);
+ return l10n_util::GetStringUTF16(IDS_APP_SHORTCUTS_SUBDIR_NAME);
+}
+
// static
bool ShellIntegration::SetAsDefaultBrowserInteractive() {
return false;

Powered by Google App Engine
This is Rietveld 408576698