chrome/browser/web_applications/web_app_linux.cc - Issue 13864015: Move app launcher and chrome apps shortcut strings into the installer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/web_applications/web_app_linux.cc

Issue 13864015: Move app launcher and chrome apps shortcut strings into the installer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@migrate_app_id_fix

Patch Set: fix linux unit tests Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/web_applications/web_app.cc ('K') | « chrome/browser/web_applications/web_app.cc ('k') | chrome/browser/web_applications/web_app_mac.mm » ('j') | chrome/installer/setup/uninstall.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/web_applications/web_app_linux.cc

diff --git a/chrome/browser/web_applications/web_app_linux.cc b/chrome/browser/web_applications/web_app_linux.cc

index d616cf0a0a1ec23db5a3992d3fe4ccd36aaa7a05..0ea6426ab082312effdd7796b0405beeac2247f4 100644

--- a/chrome/browser/web_applications/web_app_linux.cc

+++ b/chrome/browser/web_applications/web_app_linux.cc

@@ -53,10 +53,6 @@ void UpdatePlatformShortcuts(

// not show it in the menu.

creation_locations.hidden = true;

- // Always create the shortcut in the Chrome Apps subdir (even if it is

- // currently in a different location).

- creation_locations.applications_menu_subdir = GetAppShortcutsSubdirName();

gab 2013/10/03 17:22:49 Shouldn't this be replaced by the boolean indicati

calamity 2013/10/14 02:24:25 I don't think so. This just specifies the director

gab 2013/10/17 15:13:31 Well the previous comment seem to say that we want

CreatePlatformShortcuts(web_app_path, shortcut_info, creation_locations,

SHORTCUT_CREATION_BY_USER);

}