chrome/browser/apps/shortcut_manager.cc - Issue 13864015: Move app launcher and chrome apps shortcut strings into the installer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/shortcut_manager.cc

Issue 13864015: Move app launcher and chrome apps shortcut strings into the installer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@migrate_app_id_fix

Patch Set: fix linux unit tests Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/apps/shortcut_manager.cc

diff --git a/chrome/browser/apps/shortcut_manager.cc b/chrome/browser/apps/shortcut_manager.cc

index 149e4a741fa836ed9deb4d8596503cc2a20ff052..3eb413d76ad8078b80afae83d0061de769c96411 100644

--- a/chrome/browser/apps/shortcut_manager.cc

+++ b/chrome/browser/apps/shortcut_manager.cc

@@ -41,10 +41,9 @@ namespace {

void CreateShortcutsInApplicationsMenu(

const ShellIntegration::ShortcutInfo& shortcut_info) {

ShellIntegration::ShortcutLocations creation_locations;

- creation_locations.in_applications_menu = true;

+ creation_locations.in_applications_menu_root = true;

gab 2013/10/03 17:22:49 We don't want it in the root, right?

calamity 2013/10/14 02:24:25 Done.

// Create the shortcut in the Chrome Apps subdir.

- creation_locations.applications_menu_subdir =

- web_app::GetAppShortcutsSubdirName();

+ creation_locations.in_applications_menu_chrome_apps_subdir = true;

web_app::CreateShortcuts(shortcut_info, creation_locations,

web_app::SHORTCUT_CREATION_AUTOMATED);

}

« no previous file with comments | « no previous file | chrome/browser/chrome_browser_main_win.cc » ('j') | chrome/browser/shell_integration.h » ('J')