Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: chrome/browser/ui/views/create_application_shortcut_view.cc

Issue 13864015: Move app launcher and chrome apps shortcut strings into the installer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@migrate_app_id_fix
Patch Set: fix win compile, change LOG(INFO)s to VLOG(1) Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/create_application_shortcut_view.cc
diff --git a/chrome/browser/ui/views/create_application_shortcut_view.cc b/chrome/browser/ui/views/create_application_shortcut_view.cc
index 8e60a54671490d40387536530bf9fdd008838f3d..1421257022f1bc1981c2373aaaf03a5666d6417b 100644
--- a/chrome/browser/ui/views/create_application_shortcut_view.cc
+++ b/chrome/browser/ui/views/create_application_shortcut_view.cc
@@ -371,9 +371,12 @@ bool CreateApplicationShortcutView::Accept() {
ShellIntegration::ShortcutLocations creation_locations;
creation_locations.on_desktop = desktop_check_box_->checked();
- creation_locations.in_applications_menu = menu_check_box_ == NULL ? false :
- menu_check_box_->checked();
- creation_locations.applications_menu_subdir = shortcut_menu_subdir_;
+ if (menu_check_box_ != NULL && menu_check_box_->checked()) {
+ creation_locations.applications_menu_location =
+ create_in_chrome_apps_subdir_ ?
+ ShellIntegration::APP_MENU_LOCATION_SUBDIR_CHROMEAPPS :
+ ShellIntegration::APP_MENU_LOCATION_ROOT;
+ }
#if defined(OS_WIN)
creation_locations.in_quick_launch_bar = quick_launch_check_box_ == NULL ?
@@ -430,8 +433,8 @@ CreateUrlApplicationShortcutView::CreateUrlApplicationShortcutView(
FetchIcon();
}
- // NOTE: Leave shortcut_menu_subdir_ blank to create URL app shortcuts in the
- // top-level menu.
+ // Create URL app shortcuts in the top-level menu.
+ create_in_chrome_apps_subdir_ = false;
InitControls();
}
@@ -522,7 +525,7 @@ CreateChromeApplicationShortcutView::CreateChromeApplicationShortcutView(
shortcut_info_.description = UTF8ToUTF16(app->description());
// Place Chrome app shortcuts in the "Chrome Apps" submenu.
- shortcut_menu_subdir_ = web_app::GetAppShortcutsSubdirName();
+ create_in_chrome_apps_subdir_ = true;
InitControls();
« no previous file with comments | « chrome/browser/ui/views/create_application_shortcut_view.h ('k') | chrome/browser/web_applications/web_app.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698