Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3708)

Unified Diff: chrome/browser/shell_integration_linux_unittest.cc

Issue 13864015: Move app launcher and chrome apps shortcut strings into the installer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@migrate_app_id_fix
Patch Set: fix linux nits Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/shell_integration_linux_unittest.cc
diff --git a/chrome/browser/shell_integration_linux_unittest.cc b/chrome/browser/shell_integration_linux_unittest.cc
index 9bf6ec4e07853705f7e3514f81727ac0d34ee541..1f5c54ed86e142c1f6ebbfabf6b17b4ccbe66dc5 100644
--- a/chrome/browser/shell_integration_linux_unittest.cc
+++ b/chrome/browser/shell_integration_linux_unittest.cc
@@ -170,7 +170,9 @@ TEST(ShellIntegrationTest, GetExistingShortcutLocations) {
ShellIntegrationLinux::GetExistingShortcutLocations(
&env, kProfilePath, kExtensionId);
EXPECT_FALSE(result.on_desktop);
- EXPECT_FALSE(result.in_applications_menu);
+ EXPECT_EQ(ShellIntegration::APP_MENU_LOCATION_NONE,
+ result.applications_menu_location);
+
EXPECT_FALSE(result.in_quick_launch_bar);
EXPECT_FALSE(result.hidden);
}
@@ -190,7 +192,9 @@ TEST(ShellIntegrationTest, GetExistingShortcutLocations) {
ShellIntegrationLinux::GetExistingShortcutLocations(
&env, kProfilePath, kExtensionId, desktop_path);
EXPECT_TRUE(result.on_desktop);
- EXPECT_FALSE(result.in_applications_menu);
+ EXPECT_EQ(ShellIntegration::APP_MENU_LOCATION_NONE,
+ result.applications_menu_location);
+
EXPECT_FALSE(result.in_quick_launch_bar);
EXPECT_FALSE(result.hidden);
}
@@ -211,7 +215,9 @@ TEST(ShellIntegrationTest, GetExistingShortcutLocations) {
ShellIntegrationLinux::GetExistingShortcutLocations(
&env, kProfilePath, kExtensionId);
EXPECT_FALSE(result.on_desktop);
- EXPECT_TRUE(result.in_applications_menu);
+ EXPECT_EQ(ShellIntegration::APP_MENU_LOCATION_SUBDIR_CHROMEAPPS,
+ result.applications_menu_location);
+
EXPECT_FALSE(result.in_quick_launch_bar);
EXPECT_FALSE(result.hidden);
}
@@ -233,7 +239,8 @@ TEST(ShellIntegrationTest, GetExistingShortcutLocations) {
&env, kProfilePath, kExtensionId);
// Doesn't count as being in applications menu.
EXPECT_FALSE(result.on_desktop);
- EXPECT_FALSE(result.in_applications_menu);
+ EXPECT_EQ(ShellIntegration::APP_MENU_LOCATION_NONE,
+ result.applications_menu_location);
EXPECT_FALSE(result.in_quick_launch_bar);
EXPECT_TRUE(result.hidden);
}
@@ -262,7 +269,8 @@ TEST(ShellIntegrationTest, GetExistingShortcutLocations) {
ShellIntegrationLinux::GetExistingShortcutLocations(
&env, kProfilePath, kExtensionId, desktop_path);
EXPECT_TRUE(result.on_desktop);
- EXPECT_TRUE(result.in_applications_menu);
+ EXPECT_EQ(ShellIntegration::APP_MENU_LOCATION_SUBDIR_CHROMEAPPS,
+ result.applications_menu_location);
EXPECT_FALSE(result.in_quick_launch_bar);
EXPECT_FALSE(result.hidden);
}

Powered by Google App Engine
This is Rietveld 408576698