Move app launcher and chrome apps shortcut strings into the installer

chrome/installer/setup/uninstall.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file defines the methods useful for uninstalling Chrome.
 
 #include "chrome/installer/setup/uninstall.h"
 
 #include <windows.h>
 
@@ skipping 336 matching lines @@
     LOG(WARNING) << "Failed to delete Desktop shortcuts.";
   }
 
   VLOG(1) << "Deleting Quick Launch shortcuts.";
   if (!ShellUtil::RemoveShortcuts(ShellUtil::SHORTCUT_LOCATION_QUICK_LAUNCH,
                                   dist, install_level, target_exe)) {
     LOG(WARNING) << "Failed to delete Quick Launch shortcuts.";
   }
 
   VLOG(1) << "Deleting Start Menu shortcuts.";
-  if (!ShellUtil::RemoveShortcuts(ShellUtil::SHORTCUT_LOCATION_START_MENU, dist,
-                                  install_level, target_exe)) {
+  if (!ShellUtil::RemoveShortcuts(
+      ShellUtil::SHORTCUT_LOCATION_START_MENU_CHROME_DIR, dist, install_level,
+      target_exe)) {
     LOG(WARNING) << "Failed to delete Start Menu shortcuts.";
   }
 

[gab, 2013/08/28 19:52:27]

Also want to add an extra block here to remove Chrome shortcuts in
SHORTCUT_LOCATION_START_MENU_CHROME_APPS_DIR and
SHORTCUT_LOCATION_START_MENU_ROOT (old v1 apps).

In fact calling RemoveShortcuts in a loop over all ShellUtil::ShortcutLocations
probably makes more sense at this point than this series of ifs.

[calamity, 2013/10/02 01:08:05]

Done.

   // Unpin all pinned-to-taskbar shortcuts that point to |chrome_exe|.
   if (!ShellUtil::RemoveShortcuts(ShellUtil::SHORTCUT_LOCATION_TASKBAR_PINS,
                                   dist, ShellUtil::CURRENT_USER, target_exe)) {
     LOG(WARNING) << "Failed to unpin taskbar shortcuts at user-level.";
   }
 
   // Delete the folder of secondary tiles from the start screen for |dist|.
   if (!ShellUtil::RemoveShortcuts(ShellUtil::SHORTCUT_LOCATION_APP_SHORTCUTS,
                                   dist, install_level, target_exe)) {
     LOG(WARNING) << "Failed to delete start-screen shortcuts.";
@@ skipping 1055 matching lines @@
     // deletion unconditionally. If they are not empty, the session manager
     // will not delete them on reboot.
     ScheduleParentAndGrandparentForDeletion(target_path);
   } else if (DeleteApplicationProductAndVendorDirectories(target_path) ==
              installer::DELETE_FAILED) {
     *uninstall_status = installer::UNINSTALL_FAILED;
   }
 }
 
 }  // namespace installer