Move app launcher and chrome apps shortcut strings into the installer

chrome/installer/util/shell_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file declares methods that are useful for integrating Chrome in
 // Windows shell. These methods are all static and currently part of
 // ShellUtil class.
 
 #ifndef CHROME_INSTALLER_UTIL_SHELL_UTIL_H_
 #define CHROME_INSTALLER_UTIL_SHELL_UTIL_H_
@@ skipping 26 matching lines @@
     UNKNOWN_DEFAULT,
     NOT_DEFAULT,
     IS_DEFAULT,
   };
 
   // Typical shortcut directories. Resolved in GetShortcutPath().
   enum ShortcutLocation {
     SHORTCUT_LOCATION_DESKTOP,
     SHORTCUT_LOCATION_QUICK_LAUNCH,
     SHORTCUT_LOCATION_START_MENU,
+    // TODO(mgiuca): add SHORTCUT_LOCATION_START_MENU_CHROME_APPS_DIR here.

[gab, 2013/04/29 21:34:44]

FYI this will conflict with https://codereview.chromium.org/14287008/

[gab, 2013/04/29 21:34:44]

I don't think a TODO is required here since none of this Chrome Apps folder
logic has been implemented yet and this might not end up being where it is
implemented...

[gab, 2013/04/29 21:45:28]

Seems indeed that https://codereview.chromium.org/14533004/ is going in another
direction (although it might be wrong and end up using ShellUtil::), looks like
you and Matt should have a chat :)!

[Matt Giuca, 2013/04/30 01:14:09]

Hi Gab,

Yes, I'm aware of this CL (it was my suggestion that Chris add me as a TODO
here). My '004 CL is required functionality for M28 so I am trying to get it
working as quickly as possible without blocking on this refactor (which might
not make it into M28). Currently the Chrome Apps shortcut creation code is
unrelated to shell_util, so it will be some degree of work to fix it.

I'm happy to remove the TODO and we'll just keep this refactor on the radar.

[gab, 2013/04/30 15:00:24]

I see, thanks for clarifying, I'd prefer not to have a TODO for now since I'm
not yet convinced this belongs here anyways.

   };
 
   enum ShortcutOperation {
     // Create a new shortcut (overwriting if necessary).
     SHELL_SHORTCUT_CREATE_ALWAYS,
     // Create the per-user shortcut only if its system-level equivalent (with
     // the same name) is not present.
     SHELL_SHORTCUT_CREATE_IF_NO_SYSTEM_LEVEL,
     // Overwrite an existing shortcut (fail if the shortcut doesn't exist).
     // If the arguments are not specified on the new shortcut, keep the old
@@ skipping 498 matching lines @@
   // required by the base32 standard for inputs that aren't a multiple of 5
   // bytes.
   static string16 ByteArrayToBase32(const uint8* bytes, size_t size);
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ShellUtil);
 };
 
 
 #endif  // CHROME_INSTALLER_UTIL_SHELL_UTIL_H_