Move app launcher and chrome apps shortcut strings into the installer

chrome/installer/util/browser_distribution.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file declares a class that contains various method related to branding.
 
 #ifndef CHROME_INSTALLER_UTIL_BROWSER_DISTRIBUTION_H_
 #define CHROME_INSTALLER_UTIL_BROWSER_DISTRIBUTION_H_
 
 #include <string>
@@ skipping 40 matching lines @@
   // IMPORTANT: This should only be called by the installer which needs to make
   // decisions on the suffixing of the upcoming install, not by external callers
   // at run-time.
   virtual string16 GetBaseAppName();
 
   // Returns the localized name of the program.
   virtual string16 GetAppShortCutName();
 
   virtual string16 GetAlternateApplicationName();
 
+  // Returns the localized name of the app launcher.
+  virtual string16 GetAppListShortcutName();
+
+  // Returns the localized name of the subdirectory to store chrome apps in the
+  // application menu.
+  virtual string16 GetAppShortcutsSubdirName();

[gab, 2013/05/15 21:26:38]

I talked about this with huangs@ and we came up with the following facts and
conclusion:

1) You will also need the icon paths + icon indexes in the distribution.
2) This would add a lot of calls :(, but here is how we mitigate this:

In BrowserDistribution:
A) Make a
ShortcutInfo GetShortcutInfo(ShortcutEnum shortcut_enum);
method; where
a) ShortcutInfo is a struct containing (shortcut_name, icon_path, icon_index) --
effectively merging the current (GetAppShortcutName, GetIconIndex, and
GetIconFilename) into a single call.
b) ShortcutEnum is an enum (e.g., SHORTCUT_CHROME, SHORTCUT_ALTERNATE_CHROME,
and now SHORTCUT_APP_LAUNCHER).

B) Add a GetStartMenuShortcutSubfolder(SubfolderEnum subfolder_enum) method to
return the appropriate folder (effectively a duplicate of the current
GetAppShortcutName() used for both purposes); where
a) SubfolderEnum is one of SUBFOLDER_CHROME, SUBFOLDER_APPS

This will avoid creating 3 more calls just for App launcher while keeping the
desired behavior.

3) You should do this in a precursor CL (mentioning this one in the description
for reference if anyone wonders why this is done); this will make it easier to
review both that CL and this one after since the refactoring will likely touch
files unrelated to this CL.

[calamity, 2013/08/27 07:59:35]

Done.

+
   // Returns the unsuffixed appid of this program.
   // The AppUserModelId is a property of Windows programs.
   // IMPORTANT: This should only be called by ShellUtil::GetAppId as the appid
   // should be suffixed in all scenarios.
   virtual string16 GetBaseAppId();
 
   virtual string16 GetInstallSubDir();
 
   virtual string16 GetPublisherName();
 
@@ skipping 61 matching lines @@
 
   const Type type_;
 
  private:
   BrowserDistribution();
 
   DISALLOW_COPY_AND_ASSIGN(BrowserDistribution);
 };
 
 #endif  // CHROME_INSTALLER_UTIL_BROWSER_DISTRIBUTION_H_