Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Side by Side Diff: chrome/installer/util/browser_distribution.cc

Issue 13864015: Move app launcher and chrome apps shortcut strings into the installer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@migrate_app_id_fix
Patch Set: fix linux Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file defines a class that contains various method related to branding. 5 // This file defines a class that contains various method related to branding.
6 // It provides only default implementations of these methods. Usually to add 6 // It provides only default implementations of these methods. Usually to add
7 // specific branding, we will need to extend this class with a custom 7 // specific branding, we will need to extend this class with a custom
8 // implementation. 8 // implementation.
9 9
10 #include "chrome/installer/util/browser_distribution.h" 10 #include "chrome/installer/util/browser_distribution.h"
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 shortcut_type == SHORTCUT_CHROME_ALTERNATE) << shortcut_type; 184 shortcut_type == SHORTCUT_CHROME_ALTERNATE) << shortcut_type;
185 return 0; 185 return 0;
186 } 186 }
187 187
188 string16 BrowserDistribution::GetIconFilename() { 188 string16 BrowserDistribution::GetIconFilename() {
189 return installer::kChromeExe; 189 return installer::kChromeExe;
190 } 190 }
191 191
192 string16 BrowserDistribution::GetStartMenuShortcutSubfolder( 192 string16 BrowserDistribution::GetStartMenuShortcutSubfolder(
193 Subfolder subfolder_type) { 193 Subfolder subfolder_type) {
194 DCHECK_EQ(subfolder_type, SUBFOLDER_CHROME); 194 switch (subfolder_type) {
195 return GetShortcutName(SHORTCUT_CHROME); 195 case SUBFOLDER_APPS:
196 return installer::GetLocalizedString(IDS_APP_SHORTCUTS_SUBDIR_NAME_BASE);
197 default:
198 DCHECK_EQ(subfolder_type, SUBFOLDER_CHROME);
199 return GetShortcutName(SHORTCUT_CHROME);
200 }
196 } 201 }
197 202
198 string16 BrowserDistribution::GetBaseAppId() { 203 string16 BrowserDistribution::GetBaseAppId() {
199 return L"Chromium"; 204 return L"Chromium";
200 } 205 }
201 206
202 string16 BrowserDistribution::GetBrowserProgIdPrefix() { 207 string16 BrowserDistribution::GetBrowserProgIdPrefix() {
203 // This used to be "ChromiumHTML", but was forced to become "ChromiumHTM" 208 // This used to be "ChromiumHTML", but was forced to become "ChromiumHTM"
204 // because of http://crbug.com/153349. See the declaration of this function 209 // because of http://crbug.com/153349. See the declaration of this function
205 // in the header file for more details. 210 // in the header file for more details.
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
293 installer::InstallStatus install_status) { 298 installer::InstallStatus install_status) {
294 } 299 }
295 300
296 bool BrowserDistribution::ShouldSetExperimentLabels() { 301 bool BrowserDistribution::ShouldSetExperimentLabels() {
297 return false; 302 return false;
298 } 303 }
299 304
300 bool BrowserDistribution::HasUserExperiments() { 305 bool BrowserDistribution::HasUserExperiments() {
301 return false; 306 return false;
302 } 307 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698