Move app launcher and chrome apps shortcut strings into the installer

chrome/browser/ui/browser_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/files/file_path.h"
@@ skipping 70 matching lines @@
 #include "net/test/spawned_test_server/spawned_test_server.h"
 #include "ui/base/l10n/l10n_util.h"
 
 #if defined(OS_MACOSX)
 #include "base/mac/mac_util.h"
 #include "base/mac/scoped_nsautorelease_pool.h"
 #include "chrome/browser/ui/cocoa/run_loop_testing.h"
 #endif
 
 #if defined(OS_WIN)
+#include <shlobj.h>  // Must be before propkey.
+#include <propkey.h>
+#include <shellapi.h>
+
 #include "base/i18n/rtl.h"
+#include "base/win/scoped_comptr.h"
+#include "base/win/scoped_propvariant.h"
+#include "base/win/windows_version.h"
 #include "chrome/browser/browser_process.h"
+#include "chrome/browser/profiles/profile_shortcut_manager_win.h"
+#include "chrome/browser/profiles/profiles_state.h"
+#include "chrome/installer/util/browser_distribution.h"
+#include "ui/views/win/hwnd_util.h"
 #endif
 
 using content::InterstitialPage;
 using content::HostZoomMap;
 using content::NavigationController;
 using content::NavigationEntry;
 using content::OpenURLParams;
 using content::Referrer;
 using content::WebContents;
 using content::WebContentsObserver;
@@ skipping 216 matching lines @@
 
   typedef std::map<content::RenderViewHost*, Sizes> RenderViewSizes;
   RenderViewSizes render_view_sizes_;
   // Enlarge WebContentsView by this size insets in NavigateToPendingEntry.
   gfx::Size wcv_resize_insets_;
   BrowserWindow* browser_window_;  // Weak ptr.
 
   DISALLOW_COPY_AND_ASSIGN(RenderViewSizeObserver);
 };
 
+#if defined(OS_WIN)

[gab, 2013/10/17 15:13:31]

Wait... isn't this part of the other change you're working on, it shouldn't be
in this one... right?!

[calamity, 2013/11/20 05:43:30]

Removed.

+
+// An observer that returns back to test code after a new profile is
+// initialized.
+void UnblockOnProfileCreation(Profile* profile,
+                              Profile::CreateStatus status) {
+  if (status == Profile::CREATE_STATUS_INITIALIZED)
+    base::MessageLoop::current()->Quit();
+}
+
+// Checks that the relaunch name, relaunch command and app icon for the given
+// |browser| are correct.
+void ValidateBrowserWindowProperties(
+    Browser* browser,
+    const base::string16& expected_profile_name) {
+  HWND hwnd = views::HWNDForNativeWindow(browser->window()->GetNativeWindow());
+
+  base::win::ScopedComPtr<IPropertyStore> pps;
+  HRESULT result = SHGetPropertyStoreForWindow(hwnd, IID_IPropertyStore,
+                                               pps.ReceiveVoid());
+  EXPECT_TRUE(SUCCEEDED(result));
+
+  base::win::ScopedPropVariant prop_var;
+  // The relaunch name should be of the form "Chromium" if there is only 1
+  // profile and "First User - Chromium" if there are more. The expected value
+  // is given by |expected_profile_name|.
+  EXPECT_EQ(S_OK, pps->GetValue(PKEY_AppUserModel_RelaunchDisplayNameResource,
+                                prop_var.Receive()));
+  EXPECT_EQ(VT_LPWSTR, prop_var.get().vt);
+  EXPECT_EQ(
+      base::FilePath(profiles::GetShortcutFilenameForProfile(
+          expected_profile_name,
+          BrowserDistribution::GetDistribution())).RemoveExtension().value(),
+      prop_var.get().pwszVal);
+  prop_var.Reset();
+
+  // The relaunch command should specify the profile.
+  EXPECT_EQ(S_OK, pps->GetValue(PKEY_AppUserModel_RelaunchCommand,
+                                prop_var.Receive()));
+  EXPECT_EQ(VT_LPWSTR, prop_var.get().vt);
+  CommandLine cmd_line(CommandLine::FromString(prop_var.get().pwszVal));
+  EXPECT_EQ(browser->profile()->GetPath().BaseName().value(),
+            cmd_line.GetSwitchValueNative(switches::kProfileDirectory));
+  prop_var.Reset();
+
+  // The app icon should be set to the profile icon.
+  EXPECT_EQ(S_OK, pps->GetValue(PKEY_AppUserModel_RelaunchIconResource,
+                                prop_var.Receive()));
+  EXPECT_EQ(VT_LPWSTR, prop_var.get().vt);
+  EXPECT_EQ(profiles::GetProfileIconPath(browser->profile()->GetPath()).value(),
+            prop_var.get().pwszVal);
+  prop_var.Reset();
+}
+
+#endif
+
 }  // namespace
 
 class BrowserTest : public ExtensionBrowserTest {
  protected:
   // In RTL locales wrap the page title with RTL embedding characters so that it
   // matches the value returned by GetWindowTitle().
   string16 LocaleWindowCaptionFromPageTitle(const string16& expected_title) {
     string16 page_title = WindowCaptionFromPageTitle(expected_title);
 #if defined(OS_WIN)
     std::string locale = g_browser_process->GetApplicationLocale();
@@ skipping 2163 matching lines @@
   exp_commit_size.Enlarge(wcv_resize_insets.width(),
                           wcv_resize_insets.height() + height_inset);
   EXPECT_EQ(exp_commit_size, rwhv_commit_size2);
   EXPECT_EQ(exp_commit_size, wcv_commit_size2);
   // Sizes of RenderWidgetHostView and WebContentsView before and after
   // WebContentsDelegate::DidNavigateMainFramePostCommit should be the same.
   EXPECT_EQ(rwhv_commit_size2,
             web_contents->GetRenderWidgetHostView()->GetViewBounds().size());
   EXPECT_EQ(wcv_commit_size2, web_contents->GetView()->GetContainerSize());
 }
+
+#if defined(OS_WIN)
+
+// Check that the window properties on Windows are properly set.
+IN_PROC_BROWSER_TEST_F(BrowserTest, WindowProperties) {
+#if defined(USE_ASH)
+  // Disable this test in Metro+Ash where Windows window properties aren't used.
+  if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kAshBrowserTests))
+    return;
+#endif
+
+  // This test checks HWND properties that are only available on Win7+.
+  if (base::win::GetVersion() < base::win::VERSION_WIN7)
+    return;
+
+  // Single profile case. The profile name should not be shown.
+  ValidateBrowserWindowProperties(browser(), base::string16());
+
+  // If multiprofile mode is not enabled, we can't test the behavior when there
+  // are multiple profiles.
+  if (!profiles::IsMultipleProfilesEnabled())
+    return;
+
+  // Two profile case. Both profile names should be shown.
+  ProfileManager* profile_manager = g_browser_process->profile_manager();
+  ProfileInfoCache& cache = profile_manager->GetProfileInfoCache();
+
+  base::FilePath path_profile2 =
+      profile_manager->GenerateNextProfileDirectoryPath();
+  profile_manager->CreateProfileAsync(path_profile2,
+                                      base::Bind(&UnblockOnProfileCreation),
+                                      string16(), string16(), std::string());
+
+  // Spin to allow profile creation to take place, loop is terminated
+  // by UnblockOnProfileCreation when the profile is created.
+  content::RunMessageLoop();
+
+  // The default profile's name should be part of the relaunch name.
+  ValidateBrowserWindowProperties(
+      browser(), UTF8ToUTF16(browser()->profile()->GetProfileName()));
+
+  // The second profile's name should be part of the relaunch name.
+  Browser* profile2_browser =
+      CreateBrowser(profile_manager->GetProfileByPath(path_profile2));
+  size_t profile2_index = cache.GetIndexOfProfileWithPath(path_profile2);
+  ValidateBrowserWindowProperties(
+      profile2_browser, cache.GetNameOfProfileAtIndex(profile2_index));
+}
+
+#endif