Move app launcher and chrome apps shortcut strings into the installer

chrome/browser/shell_integration.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SHELL_INTEGRATION_H_
 #define CHROME_BROWSER_SHELL_INTEGRATION_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 92 matching lines @@
     base::FilePath extension_path;
     gfx::ImageFamily favicon;
     base::FilePath profile_path;
     std::string profile_name;
   };
 
   // Info about which locations to create app shortcuts in.
   struct ShortcutLocations {
     ShortcutLocations();
 
+    bool InApplicationsMenu() const {
+      return in_applications_menu_root || in_applications_menu_chrome_subdir ||
+          in_applications_menu_chrome_apps_subdir;
+    }
+
     bool on_desktop;
-    bool in_applications_menu;
-    string16 applications_menu_subdir;
+
+    // For Windows, these refer to "Start Menu", "Start Menu/Google Chrome",
+    // and "Start Menu/Chrome Apps" respectively.
+    bool in_applications_menu_root;
+    bool in_applications_menu_chrome_subdir;
+    bool in_applications_menu_chrome_apps_subdir;

[gab, 2013/10/03 17:22:49]

I don't think we ever need more than 1 of those at once; how about we make this
a single variable with enum?

e.g.,

ApplicationsMenuLocation {
  APP_LOCATION_NONE,
  APP_LOCATION_ROOT,
  APP_LOCATION_SUBDIR_CHROME,
  APP_LOCATION_SUBDIR_CHROMEAPPS,
}

[calamity, 2013/10/14 02:24:25]

Done.

 
     // For Windows, this refers to quick launch bar prior to Win7. In Win7,
     // this means "pin to taskbar". For Mac/Linux, this could be used for
     // Mac dock or the gnome/kde application launcher. However, those are not
     // implemented yet.
     bool in_quick_launch_bar;
 
     // For Linux, this refers to a shortcut which the system knows about (for
     // the purpose of identifying windows and giving them the correct
     // title/icon), but which does not show up in menus or search results.
-    // Ignored if in_applications_menu == true.
+    // Ignored if InApplicationsMenu() == true.
     bool hidden;
   };
 
   // Data that needs to be passed between the app launcher stub and Chrome.
   struct AppModeInfo {
   };
   static void SetAppModeInfo(const AppModeInfo* info);
   static const AppModeInfo* AppModeInfo();
 
   // Is the current instance of Chrome running in App mode.
@@ skipping 189 matching lines @@
     // Set Chrome as the default handler for this protocol.
     virtual bool SetAsDefault(bool interactive_permitted) OVERRIDE;
 
     std::string protocol_;
 
     DISALLOW_COPY_AND_ASSIGN(DefaultProtocolClientWorker);
   };
 };
 
 #endif  // CHROME_BROWSER_SHELL_INTEGRATION_H_