Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 13864010: MIPS: Generators can resume (Closed)

Created:
7 years, 8 months ago by palfia
Modified:
7 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Generators can resume Port r14415 (d358defa) and r14424 (7b549ce7) Original commit message: The generator object methods "next", "send", and "throw" now include some inline assembly to set up a resumed stack frame. In some common cases, we can just jump back into the frame to resume it. Otherwise the resume code calls out to a runtime to fill in the operand stack, rewind the handlers, and possibly to throw an exception. BUG=v8:2355 TESTS=mjsunit/harmony/generators-iteration Committed: https://code.google.com/p/v8/source/detail?r=14428

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -0 lines) Patch
M src/mips/full-codegen-mips.cc View 1 chunk +91 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
7 years, 8 months ago (2013-04-24 22:19:58 UTC) #1
Paul Lind
lgtm
7 years, 8 months ago (2013-04-24 23:06:31 UTC) #2
palfia
7 years, 8 months ago (2013-04-24 23:11:55 UTC) #3
Message was sent while issue was closed.
Committed manually as r14428 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698