src/parser.cc - Issue 1386383003: [cleanup] Use NewVariableProxy() instead of NewUnresolved where possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parser.cc

Issue 1386383003: [cleanup] Use NewVariableProxy() instead of NewUnresolved where possible (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/parser.cc

diff --git a/src/parser.cc b/src/parser.cc

index 7cf81c4f0569b0d770bf6751cc3f26a814a2a9aa..4ddb6c18fc46e28c706c0b229255a2e81fa2a32a 100644

--- a/src/parser.cc

+++ b/src/parser.cc

@@ -4731,8 +4731,7 @@ ZoneList<Statement*>* Parser::ParseEagerFunctionBody(

proxy, fvar_mode, scope_, RelocInfo::kNoPosition);

scope_->DeclareFunctionVar(fvar_declaration);

- VariableProxy* fproxy = scope_->NewUnresolved(factory(), function_name);

- fproxy->BindTo(fvar);

+ VariableProxy* fproxy = factory()->NewVariableProxy(fvar);

result->Set(kFunctionNameAssignmentIndex,

factory()->NewExpressionStatement(

factory()->NewAssignment(fvar_init_op, fproxy,

« no previous file with comments | « no previous file | no next file » | no next file with comments »