Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1386383003: [cleanup] Use NewVariableProxy() instead of NewUnresolved where possible (Closed)

Created:
5 years, 2 months ago by adamk
Modified:
5 years, 2 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Use NewVariableProxy() instead of NewUnresolved where possible Committed: https://crrev.com/bef2fbcc690784f554d3b688da02b9efc38fd7df Cr-Commit-Position: refs/heads/master@{#31202}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/parser.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
Another tiny cleanup found while surveying Parser code.
5 years, 2 months ago (2015-10-09 21:23:30 UTC) #2
Dan Ehrenberg
lgtm
5 years, 2 months ago (2015-10-09 21:26:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1386383003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1386383003/1
5 years, 2 months ago (2015-10-09 21:27:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-09 21:47:51 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 21:49:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bef2fbcc690784f554d3b688da02b9efc38fd7df
Cr-Commit-Position: refs/heads/master@{#31202}

Powered by Google App Engine
This is Rietveld 408576698