Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1386363003: Fix crashes on iOS related to using window.performance and reading window.location.href in a UIWebV… (Closed)

Created:
5 years, 2 months ago by georgen
Modified:
5 years, 2 months ago
Reviewers:
mdjones
Base URL:
https://github.com/chromium/dom-distiller.git@master
Visibility:
Public.

Description

Fix iOS crash related to window.performance Fix crashes on iOS related to using window.performance and reading window.location.href in a UIWebView. You must set the global variable distiller_on_ios=true prior to evaluating the distiller. BUG= R=mdjones@chromium.org Committed: e55d6a44018f67a43a41493db0822a41f958c797

Patch Set 1 #

Patch Set 2 : Fix crashes on iOS related to using window.performance and reading window.location.href in a UIWebV… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M java/org/chromium/distiller/DomDistiller.java View 1 chunk +3 lines, -1 line 0 comments Download
M java/org/chromium/distiller/DomUtil.java View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mdjones
lgtm
5 years, 2 months ago (2015-10-10 01:03:09 UTC) #2
mdjones
Before I land this, are you okay with your @google.com email being used on github?
5 years, 2 months ago (2015-10-10 01:14:46 UTC) #3
wychen
On 2015/10/10 01:14:46, mdjones wrote: > Before I land this, are you okay with your ...
5 years, 2 months ago (2015-10-10 03:05:16 UTC) #4
georgen
On 2015/10/10 03:05:16, wychen wrote: > On 2015/10/10 01:14:46, mdjones wrote: > > Before I ...
5 years, 2 months ago (2015-10-13 17:27:28 UTC) #5
mdjones
5 years, 2 months ago (2015-10-13 17:48:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e55d6a44018f67a43a41493db0822a41f958c797 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698