Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1386333003: Revert of [tracing] Display the locked size of discardable memory segment. (Closed)

Created:
5 years, 2 months ago by ssid
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, gavinp+memory_chromium.org, jam, Primiano Tucci (use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [tracing] Display the locked size of discardable memory segment. (patchset #8 id:200001 of https://codereview.chromium.org/1374213002/ ) Reason for revert: Speculative revert for the bug: www.crbug.com/541029 Original issue's description: > [tracing] Display the locked size of discardable memory segment. > > The locked size of the discardable memory segments is now displayed on > tracing. The browser side can only tell if the whole segment is locked > or not, if the segment is shared with a child. The child side can also > tell how much memory in the segment is locked. > > BUG=529943 > > Committed: https://crrev.com/a29f3c7b772a058c69b91d393740b85d7d23526b > Cr-Commit-Position: refs/heads/master@{#352004} TBR=reveman@chromium.org,avi@chromium.org,thestig@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=529943 Committed: https://crrev.com/759242daa7de8683f62885673b5dfba75679727b Cr-Commit-Position: refs/heads/master@{#353260}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -56 lines) Patch
M base/memory/discardable_shared_memory.h View 1 chunk +0 lines, -3 lines 0 comments Download
M base/memory/discardable_shared_memory.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M base/memory/discardable_shared_memory_unittest.cc View 5 chunks +1 line, -10 lines 0 comments Download
M content/child/child_discardable_shared_memory_manager.cc View 5 chunks +0 lines, -7 lines 0 comments Download
M content/common/discardable_shared_memory_heap.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/common/discardable_shared_memory_heap.cc View 4 chunks +7 lines, -18 lines 0 comments Download
M content/common/host_discardable_shared_memory_manager.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ssid
Created Revert of [tracing] Display the locked size of discardable memory segment.
5 years, 2 months ago (2015-10-09 10:34:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1386333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1386333003/1
5 years, 2 months ago (2015-10-09 10:36:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-09 10:37:06 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/759242daa7de8683f62885673b5dfba75679727b Cr-Commit-Position: refs/heads/master@{#353260}
5 years, 2 months ago (2015-10-09 10:38:40 UTC) #5
ssid
5 years, 2 months ago (2015-10-13 14:57:10 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1407483003/ by ssid@chromium.org.

The reason for reverting is: Reland after the fix..

Powered by Google App Engine
This is Rietveld 408576698