Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: src/code-stubs.cc

Issue 13863022: Fix bug in CompareNil IC (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/mjsunit/compare-nil.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 413 matching lines...) Expand 10 before | Expand all | Expand 10 after
424 } else { 424 } else {
425 return CompareNilICStub::kCompareAgainstUndefined; 425 return CompareNilICStub::kCompareAgainstUndefined;
426 } 426 }
427 } else { 427 } else {
428 if (object->IsNull()) { 428 if (object->IsNull()) {
429 types = static_cast<CompareNilICStub::Types>( 429 types = static_cast<CompareNilICStub::Types>(
430 types | CompareNilICStub::kCompareAgainstNull); 430 types | CompareNilICStub::kCompareAgainstNull);
431 } else if (object->IsUndefined()) { 431 } else if (object->IsUndefined()) {
432 types = static_cast<CompareNilICStub::Types>( 432 types = static_cast<CompareNilICStub::Types>(
433 types | CompareNilICStub::kCompareAgainstUndefined); 433 types | CompareNilICStub::kCompareAgainstUndefined);
434 } else if (object->IsUndetectableObject() || !object->IsHeapObject()) { 434 } else if (object->IsUndetectableObject() ||
435 object->IsOddball() ||
436 !object->IsHeapObject()) {
435 types = CompareNilICStub::kFullCompare; 437 types = CompareNilICStub::kFullCompare;
436 } else if ((types & CompareNilICStub::kCompareAgainstMonomorphicMap) != 0) { 438 } else if ((types & CompareNilICStub::kCompareAgainstMonomorphicMap) != 0) {
437 types = CompareNilICStub::kFullCompare; 439 types = CompareNilICStub::kFullCompare;
438 } else { 440 } else {
439 types = static_cast<CompareNilICStub::Types>( 441 types = static_cast<CompareNilICStub::Types>(
440 types | CompareNilICStub::kCompareAgainstMonomorphicMap); 442 types | CompareNilICStub::kCompareAgainstMonomorphicMap);
441 } 443 }
442 } 444 }
443 return types; 445 return types;
444 } 446 }
(...skipping 284 matching lines...) Expand 10 before | Expand all | Expand 10 after
729 } else if (argument_count >= 2) { 731 } else if (argument_count >= 2) {
730 argument_count_ = MORE_THAN_ONE; 732 argument_count_ = MORE_THAN_ONE;
731 } else { 733 } else {
732 UNREACHABLE(); 734 UNREACHABLE();
733 } 735 }
734 ArrayConstructorStubBase::GenerateStubsAheadOfTime(isolate); 736 ArrayConstructorStubBase::GenerateStubsAheadOfTime(isolate);
735 } 737 }
736 738
737 739
738 } } // namespace v8::internal 740 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/compare-nil.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698