Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Issue 13863012: Refactor List.setRange function. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index 899a509fe50a3f9c5457254723de0d238ba6acfe..798d7e45211b51cadb3f134dcdbedfcdd736af87 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -7545,7 +7545,7 @@ class DomMimeTypeArray extends NativeFieldWrapperClass1 implements List<DomMimeT
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<DomMimeType> from, [int startFrom]) {
+ void setRange(int start, int end, List<DomMimeType> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -7834,7 +7834,7 @@ class DomPluginArray extends NativeFieldWrapperClass1 implements List<DomPlugin>
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<DomPlugin> from, [int startFrom]) {
+ void setRange(int start, int end, List<DomPlugin> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -8202,7 +8202,7 @@ class DomStringList extends NativeFieldWrapperClass1 implements List<String> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<String> from, [int startFrom]) {
+ void setRange(int start, int end, List<String> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -8468,8 +8468,7 @@ class _ChildrenElementList extends ListBase<Element> {
return _childElements.fold(initialValue, combine);
}
- void setRange(int start, int rangeLength, List from,
- [int startFrom = 0]) {
+ void setRange(int start, int end, List from, [int startFrom = 0]) {
throw new UnimplementedError();
}
@@ -8627,8 +8626,7 @@ class _FrozenElementList extends ListBase {
throw new UnsupportedError('');
}
- void setRange(int start, int rangeLength, List from,
- [int startFrom = 0]) {
+ void setRange(int start, int end, List from, [int startFrom = 0]) {
throw new UnsupportedError('');
}
@@ -10911,7 +10909,7 @@ class FileList extends NativeFieldWrapperClass1 implements List<File> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<File> from, [int startFrom]) {
+ void setRange(int start, int end, List<File> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -11438,7 +11436,7 @@ class Float32Array extends ArrayBufferView implements List<double> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<num> from, [int startFrom]) {
+ void setRange(int start, int end, List<num> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -11694,7 +11692,7 @@ class Float64Array extends ArrayBufferView implements List<double> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<num> from, [int startFrom]) {
+ void setRange(int start, int end, List<num> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -12399,7 +12397,7 @@ class HtmlAllCollection extends NativeFieldWrapperClass1 implements List<Node> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<Node> from, [int startFrom]) {
+ void setRange(int start, int end, List<Node> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -12629,7 +12627,7 @@ class HtmlCollection extends NativeFieldWrapperClass1 implements List<Node> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<Node> from, [int startFrom]) {
+ void setRange(int start, int end, List<Node> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -15007,7 +15005,7 @@ class Int16Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<int> from, [int startFrom]) {
+ void setRange(int start, int end, List<int> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -15263,7 +15261,7 @@ class Int32Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<int> from, [int startFrom]) {
+ void setRange(int start, int end, List<int> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -15519,7 +15517,7 @@ class Int8Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<int> from, [int startFrom]) {
+ void setRange(int start, int end, List<int> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -18269,7 +18267,7 @@ class _ChildNodeListLazy extends ListBase<Node> {
}
// FIXME: implement these.
- void setRange(int start, int rangeLength, List<Node> from, [int startFrom]) {
+ void setRange(int start, int end, List<Node> from, [int startFrom]) {
throw new UnsupportedError(
"Cannot setRange on immutable List.");
}
@@ -18847,7 +18845,7 @@ class NodeList extends NativeFieldWrapperClass1 implements List<Node> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<Node> from, [int startFrom]) {
+ void setRange(int start, int end, List<Node> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -21434,7 +21432,7 @@ class SourceBufferList extends EventTarget implements List<SourceBuffer> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<SourceBuffer> from, [int startFrom]) {
+ void setRange(int start, int end, List<SourceBuffer> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -21773,7 +21771,7 @@ class SpeechGrammarList extends NativeFieldWrapperClass1 implements List<SpeechG
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<SpeechGrammar> from, [int startFrom]) {
+ void setRange(int start, int end, List<SpeechGrammar> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -23527,7 +23525,7 @@ class TextTrackCueList extends NativeFieldWrapperClass1 implements List<TextTrac
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<TextTrackCue> from, [int startFrom]) {
+ void setRange(int start, int end, List<TextTrackCue> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -23757,7 +23755,7 @@ class TextTrackList extends EventTarget implements List<TextTrack> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<TextTrack> from, [int startFrom]) {
+ void setRange(int start, int end, List<TextTrack> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -24204,7 +24202,7 @@ class TouchList extends NativeFieldWrapperClass1 implements List<Touch> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<Touch> from, [int startFrom]) {
+ void setRange(int start, int end, List<Touch> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -24734,7 +24732,7 @@ class Uint16Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<int> from, [int startFrom]) {
+ void setRange(int start, int end, List<int> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -24990,7 +24988,7 @@ class Uint32Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<int> from, [int startFrom]) {
+ void setRange(int start, int end, List<int> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -25246,7 +25244,7 @@ class Uint8Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<int> from, [int startFrom]) {
+ void setRange(int start, int end, List<int> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -25500,7 +25498,7 @@ class Uint8ClampedArray extends Uint8Array implements List<int> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<int> from, [int startFrom]) {
+ void setRange(int start, int end, List<int> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -27619,7 +27617,7 @@ class _ClientRectList extends NativeFieldWrapperClass1 implements List<Rect> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<Rect> from, [int startFrom]) {
+ void setRange(int start, int end, List<Rect> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -27854,7 +27852,7 @@ class _CssRuleList extends NativeFieldWrapperClass1 implements List<CssRule> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<CssRule> from, [int startFrom]) {
+ void setRange(int start, int end, List<CssRule> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -28076,7 +28074,7 @@ class _CssValueList extends _CSSValue implements List<_CSSValue> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<_CSSValue> from, [int startFrom]) {
+ void setRange(int start, int end, List<_CSSValue> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -28534,7 +28532,7 @@ class _EntryArray extends NativeFieldWrapperClass1 implements List<Entry> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<Entry> from, [int startFrom]) {
+ void setRange(int start, int end, List<Entry> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -28756,7 +28754,7 @@ class _EntryArraySync extends NativeFieldWrapperClass1 implements List<_EntrySyn
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<_EntrySync> from, [int startFrom]) {
+ void setRange(int start, int end, List<_EntrySync> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -29039,7 +29037,7 @@ class _GamepadList extends NativeFieldWrapperClass1 implements List<Gamepad> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<Gamepad> from, [int startFrom]) {
+ void setRange(int start, int end, List<Gamepad> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -29352,7 +29350,7 @@ class _NamedNodeMap extends NativeFieldWrapperClass1 implements List<Node> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<Node> from, [int startFrom]) {
+ void setRange(int start, int end, List<Node> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -29659,7 +29657,7 @@ class _SpeechInputResultList extends NativeFieldWrapperClass1 implements List<Sp
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<SpeechInputResult> from, [int startFrom]) {
+ void setRange(int start, int end, List<SpeechInputResult> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -29881,7 +29879,7 @@ class _SpeechRecognitionResultList extends NativeFieldWrapperClass1 implements L
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<SpeechRecognitionResult> from, [int startFrom]) {
+ void setRange(int start, int end, List<SpeechRecognitionResult> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -30103,7 +30101,7 @@ class _StyleSheetList extends NativeFieldWrapperClass1 implements List<StyleShee
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<StyleSheet> from, [int startFrom]) {
+ void setRange(int start, int end, List<StyleSheet> from, [int startFrom]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -32702,8 +32700,8 @@ class _WrappedList<E> implements List<E> {
Iterable<E> getRange(int start, int end) => _list.getRange(start, end);
- void setRange(int start, int length, List<E> from, [int startFrom]) {
- _list.setRange(start, length, from, startFrom);
+ void setRange(int start, int end, List<E> from, [int startFrom]) {
+ _list.setRange(start, end, from, startFrom);
}
void removeRange(int start, int length) { _list.removeRange(start, length); }

Powered by Google App Engine
This is Rietveld 408576698