tools/dom/templates/html/impl/impl_Node.darttemplate - Issue 13863012: Refactor List.setRange function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/templates/html/impl/impl_Node.darttemplate

Issue 13863012: Refactor List.setRange function. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed comments. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dom/templates/html/impl/impl_Node.darttemplate

diff --git a/tools/dom/templates/html/impl/impl_Node.darttemplate b/tools/dom/templates/html/impl/impl_Node.darttemplate

index cb664d6e721bc8dfc1ad3563a1f316c9871ca90b..b030b03351604efd39975d356867244667ee35d2 100644

--- a/tools/dom/templates/html/impl/impl_Node.darttemplate

+++ b/tools/dom/templates/html/impl/impl_Node.darttemplate

@@ -152,7 +152,8 @@ $endif

}

// FIXME: implement these.

- void setRange(int start, int rangeLength, List<Node> from, [int startFrom]) {

+ void setRange(int start, int end, Iterable<Node> iterable,

+ [int skipCount = 0]) {

throw new UnsupportedError(

"Cannot setRange on immutable List.");

}