tests/standalone/io/secure_server_socket_test.dart - Issue 13863012: Refactor List.setRange function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/standalone/io/secure_server_socket_test.dart

Issue 13863012: Refactor List.setRange function. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed comments. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/standalone/io/secure_server_socket_test.dart

diff --git a/tests/standalone/io/secure_server_socket_test.dart b/tests/standalone/io/secure_server_socket_test.dart

index da71e0d819f8ea56c9f7b51302001f4ddd01d7f1..048f9870e30214e9c9c22919f45a7274a5d7e073 100644

--- a/tests/standalone/io/secure_server_socket_test.dart

+++ b/tests/standalone/io/secure_server_socket_test.dart

@@ -167,7 +167,7 @@ void testSimpleReadWrite() {

client.listen(

(buffer) {

Expect.isTrue(bytesWritten == 0);

- data.setRange(bytesRead, buffer.length, buffer);

+ data.setRange(bytesRead, bytesRead + buffer.length, buffer);

bytesRead += buffer.length;

if (bytesRead == data.length) {

verifyTestData(data);

@@ -189,7 +189,7 @@ void testSimpleReadWrite() {

socket.close(); // Can also be delayed.

socket.listen(

(List<int> buffer) {

- dataReceived.setRange(bytesRead, buffer.length, buffer);

+ dataReceived.setRange(bytesRead, bytesRead + buffer.length, buffer);

bytesRead += buffer.length;

onDone: () {