Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Unified Diff: sdk/lib/svg/dart2js/svg_dart2js.dart

Issue 13863012: Refactor List.setRange function. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/io/websocket_impl.dart ('k') | sdk/lib/svg/dartium/svg_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/svg/dart2js/svg_dart2js.dart
diff --git a/sdk/lib/svg/dart2js/svg_dart2js.dart b/sdk/lib/svg/dart2js/svg_dart2js.dart
index d517af0836d0a7026b545a081d2c41a7307d836d..109121794808397461094f3e1e7d4cf61fcff287 100644
--- a/sdk/lib/svg/dart2js/svg_dart2js.dart
+++ b/sdk/lib/svg/dart2js/svg_dart2js.dart
@@ -3168,7 +3168,7 @@ class LengthList implements JavaScriptIndexingBehavior, List<Length> native "*SV
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<Length> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<Length> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -3800,7 +3800,7 @@ class NumberList implements JavaScriptIndexingBehavior, List<Number> native "*SV
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<Number> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<Number> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -4663,7 +4663,7 @@ class PathSegList implements JavaScriptIndexingBehavior, List<PathSeg> native "*
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<PathSeg> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<PathSeg> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -5556,7 +5556,7 @@ class StringList implements JavaScriptIndexingBehavior, List<String> native "*SV
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<String> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<String> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -6722,7 +6722,7 @@ class TransformList implements List<Transform>, JavaScriptIndexingBehavior nativ
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<Transform> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<Transform> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -7249,7 +7249,7 @@ class _ElementInstanceList implements JavaScriptIndexingBehavior, List<ElementIn
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<ElementInstance> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<ElementInstance> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
« no previous file with comments | « sdk/lib/io/websocket_impl.dart ('k') | sdk/lib/svg/dartium/svg_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698