sdk/lib/io/file_impl.dart - Issue 13863012: Refactor List.setRange function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/io/file_impl.dart

Issue 13863012: Refactor List.setRange function. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed comments. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/io/file_impl.dart

diff --git a/sdk/lib/io/file_impl.dart b/sdk/lib/io/file_impl.dart

index 83952b17ee5a6e747c0fe877ca6cc8fa171cb272..87f3204146923004fad04b666f80e7073b8a14b2 100644

--- a/sdk/lib/io/file_impl.dart

+++ b/sdk/lib/io/file_impl.dart

@@ -736,7 +736,7 @@ class _RandomAccessFile extends _FileBase implements RandomAccessFile {

}

var read = response[1];

var data = response[2];

- buffer.setRange(offset, read, data);

+ buffer.setRange(offset, offset + read, data);

return read;

});

}

« no previous file with comments | « sdk/lib/io/buffer_list.dart ('k') | sdk/lib/io/mime_multipart_parser.dart » ('j') | no next file with comments »