Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: sdk/lib/core/list.dart

Issue 13863012: Refactor List.setRange function. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/collection/queue.dart ('k') | sdk/lib/html/dart2js/html_dart2js.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/core/list.dart
diff --git a/sdk/lib/core/list.dart b/sdk/lib/core/list.dart
index 27a857e9df442afb0bc957bb4f861fe10537009b..470d8ce80171fd92ca0cfbf07b14d5cea7177ff5 100644
--- a/sdk/lib/core/list.dart
+++ b/sdk/lib/core/list.dart
@@ -263,15 +263,19 @@ abstract class List<E> implements Iterable<E> {
Iterable<E> getRange(int start, int end);
/**
- * Copies [length] elements of [from], starting
- * at [startFrom], into the list, starting at [start].
- * If [length] is 0, this method does not do anything.
- * Throws an [ArgumentError] if [length] is negative.
- * Throws an [RangeError] if [start] or
- * [:start + length - 1:] are out of range for [:this:], or if
- * [startFrom] or [:startFrom + length - 1:] are out of range for [from].
+ * Copies the elements of [iterable], skipping the [skipCount] first elements
+ * into the range [start] - [end] of `this`.
+ *
+ * If [start] equals [end] and represent a legal range, this method has
+ * no effect.
+ *
+ * It is an error if [start]..[end] is not a valid range pointing into the
+ * `this`.
+ *
+ * It is an error if the [iterable] does not have enough elements after
+ * skipping [skipCount] elements.
*/
- void setRange(int start, int length, List<E> from, [int startFrom]);
+ void setRange(int start, int end, Iterable<E> iterable, [int skipCount = 0]);
/**
* Removes [length] elements from the list, beginning at [start].
« no previous file with comments | « sdk/lib/collection/queue.dart ('k') | sdk/lib/html/dart2js/html_dart2js.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698