Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: runtime/lib/typeddata.dart

Issue 13863012: Refactor List.setRange function. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/growable_array.dart ('k') | runtime/tests/vm/dart/byte_array_optimized_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/typeddata.dart
diff --git a/runtime/lib/typeddata.dart b/runtime/lib/typeddata.dart
index ff281ab7abd212c50c894cb87d6fa43497d62490..b7acbd2a992bcab525578d1eb548c873942a370b 100644
--- a/runtime/lib/typeddata.dart
+++ b/runtime/lib/typeddata.dart
@@ -568,10 +568,10 @@ abstract class _TypedListBase {
return IterableMixinWorkaround.getRangeList(this, start, end);
}
- void setRange(int start, int length, List from, [int startFrom = 0]) {
- if (!_setRange(start, length, from, startFrom)) {
+ void setRange(int start, int end, Iterable iterable, [int skipCount = 0]) {
+ if (!_setRange(start, end - start, iterable, skipCount)) {
IterableMixinWorkaround.setRangeList(this, start,
- length, from, startFrom);
+ end, iterable, skipCount);
}
}
@@ -585,7 +585,7 @@ abstract class _TypedListBase {
// Internal utility methods.
- bool _setRange(int start, int length, List from, startFrom)
+ bool _setRange(int start, int length, Iterable from, int startFrom)
native "TypedData_setRange";
}
« no previous file with comments | « runtime/lib/growable_array.dart ('k') | runtime/tests/vm/dart/byte_array_optimized_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698