runtime/lib/function_patch.dart - Issue 13863012: Refactor List.setRange function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/function_patch.dart

Issue 13863012: Refactor List.setRange function. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed comments. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/lib/function_patch.dart

diff --git a/runtime/lib/function_patch.dart b/runtime/lib/function_patch.dart

index 56b817dada646d2dd478ea2caebbc8c1aa264c47..68497a5fc4674efbb78f8248ba965c4dc835b55f 100644

--- a/runtime/lib/function_patch.dart

+++ b/runtime/lib/function_patch.dart

@@ -15,7 +15,7 @@ patch class Function {

int numArguments = numPositionalArguments + numNamedArguments;

List arguments = new List(numArguments);

arguments[0] = function;

- arguments.setRange(1, numPositionalArguments - 1, positionalArguments);

+ arguments.setRange(1, numPositionalArguments, positionalArguments);

List names = new List(numNamedArguments);

int argumentIndex = numPositionalArguments;

int nameIndex = 0;

« no previous file with comments | « runtime/lib/array.dart ('k') | runtime/lib/growable_array.dart » ('j') | no next file with comments »