Refactor List.setRange function.

utils/tests/string_encoding/benchmark_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of BenchmarkTests;
 
 /**
  * The results of a single block of tests (count times run, overall time).
  */
 class BlockSample {
@@ skipping 159 matching lines @@
   String _leftAlign(String s, int width) {
     List<int> outCodes = [];
     outCodes.insertRange(0, width, spaceChar);
     outCodes.setRange(0, Math.min(width, s.length), s.codeUnits);
     return new String.fromCharCodes(outCodes);
   }
 
   String _rightAlign(String s, int width) {
     List<int> outCodes = [];
     outCodes.insertRange(0, width, spaceChar);
-    outCodes.setRange(Math.max(0, width - s.length), Math.min(width, s.length),
-        s.codeUnits);
+    int fromIndex = Math.max(0, width - s.length);
+    int length = Math.min(width, s.length);
+    outCodes.setRange(fromIndex, fromIndex + length, s.codeUnits);
     return new String.fromCharCodes(outCodes);
   }
 
   static String _stringifyDoubleAsInt(double val) {
     if (val.isInfinite || val.isNaN) {
       return "NaN";
     } else {
       return val.toInt().toString();
     }
   }
@@ skipping 259 matching lines @@
         _(TestReport r) => r.printReport() : reportHandler;
   }
 
   Function _reportHandler;
   Function get reportHandler => _reportHandler;
   int _warmup;
   int _targetTimeMs;
   int _minSampleTimeMs;
   int _blocksize;
 }