Refactor List.setRange function.

tests/standalone/float_array_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // Dart test program for testing native float arrays.
 
 // Library tag to be able to run in html test framework.
 library FloatArrayTest;
 
 import "package:expect/expect.dart";
@@ skipping 23 matching lines @@
 
   floatArray[0] = 20.0;
   floatArray[1] = 21.0;
   floatArray[2] = 22.0;
   list.setRange(0, 3, floatArray);
   for (int i = 0; i < 3; i++) {
     Expect.equals(20 + i, list[i]);
   }
 
   // 4.0e40 is larger than the largest representable float.
-  floatArray.setRange(1, 2, const [8.0, 4.0e40]);
+  floatArray.setRange(1, 3, const [8.0, 4.0e40]);
   Expect.equals(20, floatArray[0]);
   Expect.equals(8, floatArray[1]);
   Expect.equals(double.INFINITY, floatArray[2]);
 }
 
 void testIndexOutOfRange32() {
   Float32List floatArray = new Float32List(3);
   List<num> list = const [0.0, 1.0, 2.0, 3.0];
 
   Expect.throws(() {
     floatArray[5] = 2.0;
   });
   Expect.throws(() {
     floatArray.setRange(0, 4, list);
   });
 
   Expect.throws(() {
-    floatArray.setRange(3, 1, list);
+    floatArray.setRange(3, 4, list);
   });
 }
 
 void testIndexOf32() {
   var list = new Float32List(10);
   for (int i = 0; i < list.length; i++) {
     list[i] = i + 10.0;
   }
   Expect.equals(0, list.indexOf(10));
   Expect.equals(5, list.indexOf(15));
@@ skipping 45 matching lines @@
 
   floatArray[0] = 20.0;
   floatArray[1] = 21.0;
   floatArray[2] = 22.0;
   list.setRange(0, 3, floatArray);
   for (int i = 0; i < 3; i++) {
     Expect.equals(20 + i, list[i]);
   }
 
   // Unlike Float32Array we can properly represent 4.0e40
-  floatArray.setRange(1, 2, const [8.0, 4.0e40]);
+  floatArray.setRange(1, 3, const [8.0, 4.0e40]);
   Expect.equals(20, floatArray[0]);
   Expect.equals(8, floatArray[1]);
   Expect.equals(4.0e40, floatArray[2]);
 }
 
 void testIndexOutOfRange64() {
   Float64List floatArray = new Float64List(3);
   List<num> list = const [0.0, 1.0, 2.0, 3.0];
 
   Expect.throws(() {
     floatArray[5] = 2.0;
   });
   Expect.throws(() {
     floatArray.setRange(0, 4, list);
   });
 
   Expect.throws(() {
-    floatArray.setRange(3, 1, list);
+    floatArray.setRange(3, 4, list);
   });
 }
 
 void testIndexOf64() {
   var list = new Float64List(10);
   for (int i = 0; i < list.length; i++) {
     list[i] = i + 10.0;
   }
   Expect.equals(0, list.indexOf(10));
   Expect.equals(5, list.indexOf(15));
@@ skipping 50 matching lines @@
   testBadValues32();
   testBadValues64();
   // Check optimized (inlined) version of []=
   Expect.throws(() {
     storeIt32(a32, 1, 2);
   });
   Expect.throws(() {
     storeIt64(a64, 1, 2);
   });
 }