Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Side-by-side diff isn't available for this file because of its large size.
Issue 13863012: Refactor List.setRange function. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | sdk/lib/html/html_common/filtered_element_list.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index 368cb64d08d6f585f3bd7594553b2a429a558e8c..b2564d7a79f3cbd443fba3f3b5ad8749cf9e816d 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -7611,7 +7611,7 @@ class DomMimeTypeArray extends NativeFieldWrapperClass1 implements List<DomMimeT
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<DomMimeType> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<DomMimeType> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -7912,7 +7912,7 @@ class DomPluginArray extends NativeFieldWrapperClass1 implements List<DomPlugin>
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<DomPlugin> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<DomPlugin> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -8340,7 +8340,7 @@ class DomStringList extends NativeFieldWrapperClass1 implements List<String> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<String> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<String> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -8605,8 +8605,8 @@ class _ChildrenElementList extends ListBase<Element> {
return _childElements.fold(initialValue, combine);
}
- void setRange(int start, int rangeLength, List from,
- [int startFrom = 0]) {
+ void setRange(int start, int end, Iterable<Element> iterable,
+ [int skipCount = 0]) {
throw new UnimplementedError();
}
@@ -8748,8 +8748,8 @@ class _FrozenElementList extends ListBase {
throw new UnsupportedError('');
}
- void setRange(int start, int rangeLength, List from,
- [int startFrom = 0]) {
+ void setRange(int start, int end, Iterable<Element> iterable,
+ [int skipCount = 0]) {
throw new UnsupportedError('');
}
@@ -11025,7 +11025,7 @@ class FileList extends NativeFieldWrapperClass1 implements List<File> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<File> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<File> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -11539,7 +11539,7 @@ class Float32Array extends ArrayBufferView implements List<double> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<num> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<num> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -11782,7 +11782,7 @@ class Float64Array extends ArrayBufferView implements List<double> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<num> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<num> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -12535,7 +12535,7 @@ class HtmlAllCollection extends NativeFieldWrapperClass1 implements List<Node> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<Node> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<Node> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -12752,7 +12752,7 @@ class HtmlCollection extends NativeFieldWrapperClass1 implements List<Node> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<Node> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<Node> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -15125,7 +15125,7 @@ class Int16Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<int> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<int> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -15368,7 +15368,7 @@ class Int32Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<int> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<int> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -15611,7 +15611,7 @@ class Int8Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<int> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<int> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -18341,7 +18341,8 @@ class _ChildNodeListLazy extends ListBase<Node> {
}
// FIXME: implement these.
- void setRange(int start, int rangeLength, List<Node> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<Node> iterable,
+ [int skipCount = 0]) {
throw new UnsupportedError(
"Cannot setRange on immutable List.");
}
@@ -18906,7 +18907,7 @@ class NodeList extends NativeFieldWrapperClass1 implements List<Node> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<Node> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<Node> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -21604,7 +21605,7 @@ class SourceBufferList extends EventTarget implements List<SourceBuffer> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<SourceBuffer> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<SourceBuffer> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -21930,7 +21931,7 @@ class SpeechGrammarList extends NativeFieldWrapperClass1 implements List<SpeechG
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<SpeechGrammar> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<SpeechGrammar> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -23671,7 +23672,7 @@ class TextTrackCueList extends NativeFieldWrapperClass1 implements List<TextTrac
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<TextTrackCue> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<TextTrackCue> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -23888,7 +23889,7 @@ class TextTrackList extends EventTarget implements List<TextTrack> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<TextTrack> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<TextTrack> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -24322,7 +24323,7 @@ class TouchList extends NativeFieldWrapperClass1 implements List<Touch> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<Touch> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<Touch> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -24839,7 +24840,7 @@ class Uint16Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<int> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<int> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -25082,7 +25083,7 @@ class Uint32Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<int> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<int> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -25325,7 +25326,7 @@ class Uint8Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<int> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<int> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -25566,7 +25567,7 @@ class Uint8ClampedArray extends Uint8Array implements List<int> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<int> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<int> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -27689,7 +27690,7 @@ class _ClientRectList extends NativeFieldWrapperClass1 implements List<Rect> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<Rect> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<Rect> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -27911,7 +27912,7 @@ class _CssRuleList extends NativeFieldWrapperClass1 implements List<CssRule> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<CssRule> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<CssRule> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -28120,7 +28121,7 @@ class _CssValueList extends _CSSValue implements List<_CSSValue> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<_CSSValue> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<_CSSValue> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -28565,7 +28566,7 @@ class _EntryArray extends NativeFieldWrapperClass1 implements List<Entry> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<Entry> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<Entry> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -28774,7 +28775,7 @@ class _EntryArraySync extends NativeFieldWrapperClass1 implements List<_EntrySyn
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<_EntrySync> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<_EntrySync> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -29044,7 +29045,7 @@ class _GamepadList extends NativeFieldWrapperClass1 implements List<Gamepad> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<Gamepad> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<Gamepad> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -29344,7 +29345,7 @@ class _NamedNodeMap extends NativeFieldWrapperClass1 implements List<Node> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<Node> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<Node> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -29638,7 +29639,7 @@ class _SpeechInputResultList extends NativeFieldWrapperClass1 implements List<Sp
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<SpeechInputResult> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<SpeechInputResult> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -29847,7 +29848,7 @@ class _SpeechRecognitionResultList extends NativeFieldWrapperClass1 implements L
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<SpeechRecognitionResult> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<SpeechRecognitionResult> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -30056,7 +30057,7 @@ class _StyleSheetList extends NativeFieldWrapperClass1 implements List<StyleShee
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int rangeLength, List<StyleSheet> from, [int startFrom]) {
+ void setRange(int start, int end, Iterable<StyleSheet> iterable, [int skipCount]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -32639,8 +32640,8 @@ class _WrappedList<E> implements List<E> {
Iterable<E> getRange(int start, int end) => _list.getRange(start, end);
- void setRange(int start, int length, List<E> from, [int startFrom]) {
- _list.setRange(start, length, from, startFrom);
+ void setRange(int start, int end, Iterable<E> iterable, [int skipCount = 0]) {
+ _list.setRange(start, end, iterable, skipCount);
}
void removeRange(int start, int length) { _list.removeRange(start, length); }
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | sdk/lib/html/html_common/filtered_element_list.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698