Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: samples/swarm/swarm_ui_lib/observable/observable.dart

Issue 13863012: Refactor List.setRange function. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/tests/vm/dart/byte_array_test.dart ('k') | sdk/lib/_collection_dev/iterable.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library observable; 5 library observable;
6 6
7 import 'dart:collection'; 7 import 'dart:collection';
8 8
9 part 'ChangeEvent.dart'; 9 part 'ChangeEvent.dart';
10 part 'EventBatch.dart'; 10 part 'EventBatch.dart';
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 i >= srcStart; i--, j--) { 246 i >= srcStart; i--, j--) {
247 dst[j] = src[i]; 247 dst[j] = src[i];
248 } 248 }
249 } else { 249 } else {
250 for (int i = srcStart, j = dstStart; i < srcStart + count; i++, j++) { 250 for (int i = srcStart, j = dstStart; i < srcStart + count; i++, j++) {
251 dst[j] = src[i]; 251 dst[j] = src[i];
252 } 252 }
253 } 253 }
254 } 254 }
255 255
256 void setRange(int start, int length, List from, [int startFrom = 0]) { 256 void setRange(int start, int end, Iterable iterable, [int skipCount = 0]) {
257 throw new UnimplementedError(); 257 throw new UnimplementedError();
258 } 258 }
259 259
260 void removeRange(int start, int length) { 260 void removeRange(int start, int length) {
261 throw new UnimplementedError(); 261 throw new UnimplementedError();
262 } 262 }
263 263
264 void insertRange(int start, int length, [initialValue = null]) { 264 void insertRange(int start, int length, [initialValue = null]) {
265 throw new UnimplementedError(); 265 throw new UnimplementedError();
266 } 266 }
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
335 // Only fire on an actual change. 335 // Only fire on an actual change.
336 if (!identical(newValue, _value)) { 336 if (!identical(newValue, _value)) {
337 final oldValue = _value; 337 final oldValue = _value;
338 _value = newValue; 338 _value = newValue;
339 recordPropertyUpdate("value", newValue, oldValue); 339 recordPropertyUpdate("value", newValue, oldValue);
340 } 340 }
341 } 341 }
342 342
343 T _value; 343 T _value;
344 } 344 }
OLDNEW
« no previous file with comments | « runtime/tests/vm/dart/byte_array_test.dart ('k') | sdk/lib/_collection_dev/iterable.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698