Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: gm/gmmain.cpp

Issue 13863009: GM: signal error if the total number of tests run was less than expected (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: invert_ifdef_check Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/gmmain.cpp
===================================================================
--- gm/gmmain.cpp (revision 8603)
+++ gm/gmmain.cpp (working copy)
@@ -1825,8 +1825,10 @@
}
gmmain.ListErrors(FLAGS_verbose);
- // TODO(epoger): in a standalone CL, enable this new check.
-#if 0
+ // TODO(epoger): Enable this check for Android, too, once we resolve
+ // https://code.google.com/p/skia/issues/detail?id=1222
+ // ('GM is unexpectedly skipping tests on Android')
+#ifndef SK_BUILD_FOR_ANDROID
epoger 2013/04/11 15:24:04 That's better. Eric, you OK with me committing th
borenet 2013/04/11 15:38:41 Yes, assuming it looks like all is well on other p
if (expectedNumberOfTests != gmmain.fTestsRun) {
gm_fprintf(stderr, "expected %d tests, but ran or skipped %d tests\n",
expectedNumberOfTests, gmmain.fTestsRun);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698