Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1386273006: [iOS][gn] Port blink_html_tokenizer to build with gn. (Closed)

Created:
5 years, 2 months ago by sdefresne
Modified:
5 years, 2 months ago
Reviewers:
droger, Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@ios_testing
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS][gn] Port blink_html_tokenizer to build with gn. BUG=459705 Committed: https://crrev.com/7fa3690e341398f681128764be6b0b14f5a79a16 Cr-Commit-Position: refs/heads/master@{#355103}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A ios/third_party/blink/BUILD.gn View 1 chunk +20 lines, -0 lines 0 comments Download
M ios/third_party/blink/blink_html_tokenizer.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
sdefresne
droger: can you review as OWNERS? dpranke: can you review .gn files?
5 years, 2 months ago (2015-10-08 11:35:48 UTC) #2
Dirk Pranke
On 2015/10/08 11:35:48, sdefresne wrote: > droger: can you review as OWNERS? > dpranke: can ...
5 years, 2 months ago (2015-10-08 17:53:34 UTC) #3
sdefresne
On 2015/10/08 at 17:53:34, dpranke wrote: > On 2015/10/08 11:35:48, sdefresne wrote: > > droger: ...
5 years, 2 months ago (2015-10-09 08:51:56 UTC) #5
droger
lgtm
5 years, 2 months ago (2015-10-09 13:11:42 UTC) #6
Dirk Pranke
lgtm
5 years, 2 months ago (2015-10-09 19:03:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1386273006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1386273006/40001
5 years, 2 months ago (2015-10-20 17:22:06 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 2 months ago (2015-10-20 18:05:06 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 18:06:35 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7fa3690e341398f681128764be6b0b14f5a79a16
Cr-Commit-Position: refs/heads/master@{#355103}

Powered by Google App Engine
This is Rietveld 408576698