Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Unified Diff: runtime/vm/timeline_analysis.h

Issue 1386263002: Add support to timeline for begin and end events (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/timeline.cc ('k') | runtime/vm/timeline_analysis.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/timeline_analysis.h
diff --git a/runtime/vm/timeline_analysis.h b/runtime/vm/timeline_analysis.h
index b49d82147d2db32ba908a45627892bdba2720849..4f733a68e904ef424d1e7b8b5c7c778b999ef9a4 100644
--- a/runtime/vm/timeline_analysis.h
+++ b/runtime/vm/timeline_analysis.h
@@ -138,6 +138,15 @@ class TimelineLabelPauseInfo : public ZoneAllocated {
// Also, may adjust |max_exclusive_micros_|.
void OnPop(int64_t exclusive_micros);
+ // Adjusts |inclusive_micros_| and |exclusive_micros_| by |micros|.
+ // Also, may adjust, |max_inclusive_micros_|.
+ void OnBeginPop(int64_t inclusive_micros,
+ int64_t exclusive_micros,
+ bool already_on_stack);
+
+ void UpdateInclusiveMicros(int64_t inclusive_micros, bool already_on_stack);
+ void UpdateExclusiveMicros(int64_t exclusive_micros);
+
// Adjust inclusive micros.
void add_inclusive_micros(int64_t delta_micros) {
inclusive_micros_ += delta_micros;
@@ -197,7 +206,8 @@ class TimelinePauses : public TimelineAnalysis {
void ProcessThread(TimelineAnalysisThread* thread);
bool CheckStack(TimelineEvent* event);
- void PopFinished(int64_t start);
+ void PopFinishedDurations(int64_t start);
+ void PopBegin(const char* label, int64_t end);
void Push(TimelineEvent* event);
bool IsLabelOnStack(const char* label) const;
intptr_t StackDepth() const;
« no previous file with comments | « runtime/vm/timeline.cc ('k') | runtime/vm/timeline_analysis.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698