Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1386253004: [turbofan] More efficient splintering. (Closed)

Created:
5 years, 2 months ago by Mircea Trofin
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, Jim Stichnoth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] More efficient splintering. For live ranges with many use positions, such as those encountered in some unity asm.js code, this change significantly reduces compile time (e.g. benchmarks/Compile/slow_nbody1.js: from ~6s to 2s). The improvement is solely due to regressions (fixed by this CL) due to splintering. This CL does not fully address compile time problems for large functions in Turbofan, but constitutes a step in the right direction. Committed: https://crrev.com/cbbfc0ff87caed730f7ba424b45563355219a14c Cr-Commit-Position: refs/heads/master@{#31220}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M src/compiler/register-allocator.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/register-allocator.cc View 6 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1386253004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1386253004/1
5 years, 2 months ago (2015-10-12 15:23:14 UTC) #2
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 2 months ago (2015-10-12 15:23:17 UTC) #4
Mircea Trofin
Note that current benchmarks, while generally positively impacted, do not highlight the same order of ...
5 years, 2 months ago (2015-10-12 15:30:18 UTC) #6
Benedikt Meurer
LGTM.
5 years, 2 months ago (2015-10-12 17:48:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1386253004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1386253004/1
5 years, 2 months ago (2015-10-12 18:25:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-12 18:34:33 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 18:34:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbbfc0ff87caed730f7ba424b45563355219a14c
Cr-Commit-Position: refs/heads/master@{#31220}

Powered by Google App Engine
This is Rietveld 408576698