Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1386233002: Pull in analyzer_cli support for enabling the new task model. (Closed)

Created:
5 years, 2 months ago by Paul Berry
Modified:
5 years, 2 months ago
Reviewers:
pquitslund
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Pull in analyzer_cli support for enabling the new task model. Note that we are not pulling in the latest version of analyzer_cli, since there is additional work to do in analyzer_cli before the pull request can be merged into master (in particular, lint support needs to be fixed--see https://github.com/dart-lang/analyzer_cli/pull/67). Instead we pull in the commit from the pull request itself, which enables the new task model but makes no other changes. R=pquitslund@google.com Committed: https://github.com/dart-lang/sdk/commit/e34b7ddf0036a31922d772ca8e482a6e70c2bbbc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 2 months ago (2015-10-06 21:23:04 UTC) #2
pquitslund
LGTM!
5 years, 2 months ago (2015-10-06 21:24:05 UTC) #3
Paul Berry
5 years, 2 months ago (2015-10-06 21:25:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e34b7ddf0036a31922d772ca8e482a6e70c2bbbc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698