Fix a typo for "--dry-run" in the usage message.

Fix a typo for "--dry-run" in the usage message.

This typo was introduced in https://codereview.chromium.org/106403003.

Rename options.dryrun to options.dry_run.

R=agable@chromium.org,dpranke@chromium.org
BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=250802

[Dirk Pranke, 2014-02-11 17:19:32]

https://codereview.chromium.org/138623008/diff/30001/fetch.py
File fetch.py (right):

https://codereview.chromium.org/138623008/diff/30001/fetch.py#newcode206
fetch.py:206: -n, --dry-run      Don't run commands, only print them.
You're correctly identifying the bug: the usage doesn't match the actual flag
name.

However, the actual flag name is inconsistent w/ the field name in the options
object; python convention maps an option name with a dash in it to an underscore
(so it should be options.dry_run, not options.dryrun).

We should also the code to be options.dry_run. That may be more than you wanted
to bite off in this simple little fix; if so let me know, as this otherwise lgtm
and I can fix the field name in a follow-up patch.

[wtc, 2014-02-11 19:15:13]

https://codereview.chromium.org/138623008/diff/30001/fetch.py
File fetch.py (right):

https://codereview.chromium.org/138623008/diff/30001/fetch.py#newcode206
fetch.py:206: -n, --dry-run      Don't run commands, only print them.

On 2014/02/11 17:19:33, Dirk Pranke wrote:
>
> We should also the code to be options.dry_run. That may be more than you
wanted
> to bite off in this simple little fix; if so let me know, as this otherwise
lgtm
> and I can fix the field name in a follow-up patch.

I'll be happy to make this change. But the CL is on my home computer, so I won't
be able to upload a new patch set until tomorrow morning.

[wtc, 2014-02-12 06:00:07]

Dirk: please review patch set 3. Thanks.

https://codereview.chromium.org/138623008/diff/100001/fetch.py
File fetch.py (right):

https://codereview.chromium.org/138623008/diff/100001/fetch.py#newcode241
fetch.py:241: return optparse.Values({'dry_run':dry_run, 'nohooks':nohooks }),
recipe, props

I am not sure about this change. I assume the single-quoted string should not be
'dry-run'.

[Dirk Pranke, 2014-02-12 21:08:03]

https://codereview.chromium.org/138623008/diff/100001/fetch.py
File fetch.py (right):

https://codereview.chromium.org/138623008/diff/100001/fetch.py#newcode241
fetch.py:241: return optparse.Values({'dry_run':dry_run, 'nohooks':nohooks }),
recipe, props
On 2014/02/12 06:00:08, wtc wrote:
> 
> I am not sure about this change. I assume the single-quoted string should not
be
> 'dry-run'.

Yup, that's the right change. LGTM, thanks!

[wtc, 2014-02-12 22:17:34]

The CQ bit was checked by wtc@chromium.org

[commit-bot: I haz the power, 2014-02-12 22:17:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wtc@chromium.org/138623008/100001

[commit-bot: I haz the power, 2014-02-12 22:19:43]

Change committed as 250802