Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1386163002: fix callers to expect only base-class from Skia effect factories (Closed)

Created:
5 years, 2 months ago by reed1
Modified:
5 years, 2 months ago
CC:
chromium-reviews, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, Rik, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, danakj, krit, f(malita), blink-reviews, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

fix callers to expect only base-class from Skia effect factories BUG=skia:4424 Committed: https://crrev.com/0e7ade0dd4a75b5b32fb14c87448d7a9b0e03175 Cr-Commit-Position: refs/heads/master@{#352653}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
reed1
5 years, 2 months ago (2015-10-06 17:33:50 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1386163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1386163002/1
5 years, 2 months ago (2015-10-06 17:36:47 UTC) #4
f(malita)
lgtm
5 years, 2 months ago (2015-10-06 17:40:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1386163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1386163002/1
5 years, 2 months ago (2015-10-06 17:41:44 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 18:50:32 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 18:52:43 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0e7ade0dd4a75b5b32fb14c87448d7a9b0e03175
Cr-Commit-Position: refs/heads/master@{#352653}

Powered by Google App Engine
This is Rietveld 408576698