[Interpreter] Add bitwise operators (Or, Xor, And) to interpreter

test/cctest/interpreter/test-interpreter.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/execution.h"
 #include "src/handles.h"
 #include "src/interpreter/bytecode-array-builder.h"
 #include "src/interpreter/interpreter.h"
@@ skipping 333 matching lines @@
     Handle<BytecodeArray> bytecode_array = builder.ToBytecodeArray();
 
     InterpreterTester tester(handles.main_isolate(), bytecode_array);
     auto callable = tester.GetCallable<>();
     Handle<Object> return_val = callable().ToHandleChecked();
     CHECK(return_val.is_identical_to(true_value));
   }
 }
 
 
-static const Token::Value kArithmeticOperators[] = {
-    Token::Value::SHL, Token::Value::SAR, Token::Value::SHR, Token::Value::ADD,
-    Token::Value::SUB, Token::Value::MUL, Token::Value::DIV, Token::Value::MOD};
-
-
 static const Token::Value kShiftOperators[] = {
     Token::Value::SHL, Token::Value::SAR, Token::Value::SHR};
 
 
+static const Token::Value kArithmeticOperators[] = {
+    Token::Value::BIT_OR, Token::Value::BIT_XOR, Token::Value::BIT_AND,
+    Token::Value::SHL,    Token::Value::SAR,     Token::Value::SHR,
+    Token::Value::ADD,    Token::Value::SUB,     Token::Value::MUL,
+    Token::Value::DIV,    Token::Value::MOD};
+
+
 static double BinaryOpC(Token::Value op, double lhs, double rhs) {
   switch (op) {
     case Token::Value::ADD:
       return lhs + rhs;
     case Token::Value::SUB:
       return lhs - rhs;
     case Token::Value::MUL:
       return lhs * rhs;
     case Token::Value::DIV:
       return lhs / rhs;
     case Token::Value::MOD:
       return std::fmod(lhs, rhs);
+    case Token::Value::BIT_OR:
+      return (v8::internal::DoubleToInt32(lhs) |
+              v8::internal::DoubleToInt32(rhs));
+    case Token::Value::BIT_XOR:
+      return (v8::internal::DoubleToInt32(lhs) ^
+              v8::internal::DoubleToInt32(rhs));
+    case Token::Value::BIT_AND:
+      return (v8::internal::DoubleToInt32(lhs) &
+              v8::internal::DoubleToInt32(rhs));
     case Token::Value::SHL: {
       int32_t val = v8::internal::DoubleToInt32(lhs);
       uint32_t count = v8::internal::DoubleToUint32(rhs) & 0x1F;
       int32_t result = val << count;
       return result;
     }
     case Token::Value::SAR: {
       int32_t val = v8::internal::DoubleToInt32(lhs);
       uint32_t count = v8::internal::DoubleToUint32(rhs) & 0x1F;
       int32_t result = val >> count;
@@ skipping 23 matching lines @@
         BytecodeArrayBuilder builder(handles.main_isolate(),
                                      handles.main_zone());
         builder.set_locals_count(1);
         builder.set_parameter_count(1);
         Register reg(0);
         int lhs = lhs_inputs[l];
         int rhs = rhs_inputs[r];
         builder.LoadLiteral(Smi::FromInt(lhs))
             .StoreAccumulatorInRegister(reg)
             .LoadLiteral(Smi::FromInt(rhs))
-            .BinaryOperation(kArithmeticOperators[o], reg, Strength::WEAK)
+            .BinaryOperation(kShiftOperators[o], reg, Strength::WEAK)
             .Return();
         Handle<BytecodeArray> bytecode_array = builder.ToBytecodeArray();
 
         InterpreterTester tester(handles.main_isolate(), bytecode_array);
         auto callable = tester.GetCallable<>();
         Handle<Object> return_value = callable().ToHandleChecked();
         Handle<Object> expected_value =
             factory->NewNumber(BinaryOpC(kShiftOperators[o], lhs, rhs));
         CHECK(return_value->SameValue(*expected_value));
       }
     }
   }
 }
 
 
 TEST(InterpreterBinaryOpsSmi) {
   int lhs_inputs[] = {3266, 1024, 0, -17, -18000};
   int rhs_inputs[] = {3266, 5, 4, 3, 2, 1, -1, -2};
   for (size_t l = 0; l < arraysize(lhs_inputs); l++) {
     for (size_t r = 0; r < arraysize(rhs_inputs); r++) {
       for (size_t o = 0; o < arraysize(kArithmeticOperators); o++) {
         HandleAndZoneScope handles;
         i::Factory* factory = handles.main_isolate()->factory();
         BytecodeArrayBuilder builder(handles.main_isolate(),
                                      handles.main_zone());
         builder.set_locals_count(1);
         builder.set_parameter_count(1);
         Register reg(0);
         int lhs = lhs_inputs[l];
-        int rhs = rhs_inputs[l];
+        int rhs = rhs_inputs[r];
         builder.LoadLiteral(Smi::FromInt(lhs))
             .StoreAccumulatorInRegister(reg)
             .LoadLiteral(Smi::FromInt(rhs))
             .BinaryOperation(kArithmeticOperators[o], reg, Strength::WEAK)
             .Return();
         Handle<BytecodeArray> bytecode_array = builder.ToBytecodeArray();
 
         InterpreterTester tester(handles.main_isolate(), bytecode_array);
         auto callable = tester.GetCallable<>();
         Handle<Object> return_value = callable().ToHandleChecked();
@@ skipping 14 matching lines @@
     for (size_t r = 0; r < arraysize(rhs_inputs); r++) {
       for (size_t o = 0; o < arraysize(kArithmeticOperators); o++) {
         HandleAndZoneScope handles;
         i::Factory* factory = handles.main_isolate()->factory();
         BytecodeArrayBuilder builder(handles.main_isolate(),
                                      handles.main_zone());
         builder.set_locals_count(1);
         builder.set_parameter_count(1);
         Register reg(0);
         double lhs = lhs_inputs[l];
-        double rhs = rhs_inputs[l];
+        double rhs = rhs_inputs[r];
         builder.LoadLiteral(factory->NewNumber(lhs))
             .StoreAccumulatorInRegister(reg)
             .LoadLiteral(factory->NewNumber(rhs))
             .BinaryOperation(kArithmeticOperators[o], reg, Strength::WEAK)
             .Return();
         Handle<BytecodeArray> bytecode_array = builder.ToBytecodeArray();
 
         InterpreterTester tester(handles.main_isolate(), bytecode_array);
         auto callable = tester.GetCallable<>();
         Handle<Object> return_value = callable().ToHandleChecked();
@@ skipping 1108 matching lines @@
       .CallRuntime(Runtime::kAdd, Register(0), 2)
       .Return();
   Handle<BytecodeArray> bytecode_array = builder.ToBytecodeArray();
 
   InterpreterTester tester(handles.main_isolate(), bytecode_array);
   auto callable = tester.GetCallable<>();
 
   Handle<Object> return_val = callable().ToHandleChecked();
   CHECK_EQ(Smi::cast(*return_val), Smi::FromInt(55));
 }