Issue 138613003: A misplaced break statement is screwing up Download.DangerousFile.Discard

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 138613003: A misplaced break statement is screwing up Download.DangerousFile.Discard (Closed)

Created:
6 years, 11 months ago by felt

Modified:
6 years, 11 months ago

Reviewers:
asanka

CC:
chromium-reviews, benjhayden+dwatch_chromium.org, asanka, darin-cc_chromium.org, jam, joi+watch-content_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

A misplaced break statement is screwing up Download.DangerousFile.Discard BUG=333309 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245174

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/browser/download/download_stats.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (0 generated)

felt

Hi asanka, please review? Tiny 1 liner to fix a bug. Adrienne

6 years, 11 months ago (2014-01-14 18:32:25 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/138613003/1

6 years, 11 months ago (2014-01-14 20:26:38 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/138613003/1

6 years, 11 months ago (2014-01-15 05:14:17 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/138613003/1

6 years, 11 months ago (2014-01-16 00:38:29 UTC) #5

Message was sent while issue was closed.

Change committed as 245174