Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: Source/WebCore/loader/HistoryController.cpp

Issue 13861033: Remove Apple's unused implementation of private browsing from WebCore (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Repatch to ToT Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebCore/html/HTMLMediaElement.cpp ('k') | Source/WebCore/loader/icon/IconDatabase.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/loader/HistoryController.cpp
diff --git a/Source/WebCore/loader/HistoryController.cpp b/Source/WebCore/loader/HistoryController.cpp
index 7d155a81590e044de2a38b4b2c39954ad6ba3675..d0f921f6b4363e8f08a62682ac3b375d3616673c 100644
--- a/Source/WebCore/loader/HistoryController.cpp
+++ b/Source/WebCore/loader/HistoryController.cpp
@@ -352,8 +352,6 @@ void HistoryController::updateForStandardLoad(HistoryUpdateType updateType)
FrameLoader* frameLoader = m_frame->loader();
- Settings* settings = m_frame->settings();
- bool needPrivacy = !settings || settings->privateBrowsingEnabled();
const KURL& historyURL = frameLoader->documentLoader()->urlForHistory();
if (!frameLoader->documentLoader()->isClientRedirect()) {
@@ -366,7 +364,7 @@ void HistoryController::updateForStandardLoad(HistoryUpdateType updateType)
updateCurrentItem();
}
- if (!historyURL.isEmpty() && !needPrivacy) {
+ if (!historyURL.isEmpty()) {
if (Page* page = m_frame->page())
addVisitedLink(page, historyURL);
}
@@ -379,8 +377,6 @@ void HistoryController::updateForRedirectWithLockedBackForwardList()
LOG(History, "WebCoreHistory: Updating History for redirect load in frame %s", m_frame->loader()->documentLoader()->title().string().utf8().data());
#endif
- Settings* settings = m_frame->settings();
- bool needPrivacy = !settings || settings->privateBrowsingEnabled();
const KURL& historyURL = m_frame->loader()->documentLoader()->urlForHistory();
if (m_frame->loader()->documentLoader()->isClientRedirect()) {
@@ -396,7 +392,7 @@ void HistoryController::updateForRedirectWithLockedBackForwardList()
parentFrame->loader()->history()->m_currentItem->setChildItem(createItem());
}
- if (!historyURL.isEmpty() && !needPrivacy) {
+ if (!historyURL.isEmpty()) {
if (Page* page = m_frame->page())
addVisitedLink(page, historyURL);
}
@@ -416,11 +412,9 @@ void HistoryController::updateForClientRedirect()
m_currentItem->clearScrollPoint();
}
- Settings* settings = m_frame->settings();
- bool needPrivacy = !settings || settings->privateBrowsingEnabled();
const KURL& historyURL = m_frame->loader()->documentLoader()->urlForHistory();
- if (!historyURL.isEmpty() && !needPrivacy) {
+ if (!historyURL.isEmpty()) {
if (Page* page = m_frame->page())
addVisitedLink(page, historyURL);
}
@@ -509,10 +503,6 @@ void HistoryController::updateForSameDocumentNavigation()
if (m_frame->document()->url().isEmpty())
return;
- Settings* settings = m_frame->settings();
- if (!settings || settings->privateBrowsingEnabled())
- return;
-
Page* page = m_frame->page();
if (!page)
return;
@@ -833,10 +823,6 @@ void HistoryController::pushState(PassRefPtr<SerializedScriptValue> stateObject,
page->backForward()->addItem(topItem.release());
- Settings* settings = m_frame->settings();
- if (!settings || settings->privateBrowsingEnabled())
- return;
-
addVisitedLink(page, KURL(ParsedURLString, urlString));
}
@@ -852,10 +838,6 @@ void HistoryController::replaceState(PassRefPtr<SerializedScriptValue> stateObje
m_currentItem->setFormData(0);
m_currentItem->setFormContentType(String());
- Settings* settings = m_frame->settings();
- if (!settings || settings->privateBrowsingEnabled())
- return;
-
ASSERT(m_frame->page());
addVisitedLink(m_frame->page(), KURL(ParsedURLString, urlString));
}
« no previous file with comments | « Source/WebCore/html/HTMLMediaElement.cpp ('k') | Source/WebCore/loader/icon/IconDatabase.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698