Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1395)

Unified Diff: build/android/pylib/utils/findbugs.py

Issue 13861026: [Android] Switch all subprocess.Popen calls to use a temporary file instead of PIPE. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/utils/findbugs.py
diff --git a/build/android/pylib/utils/findbugs.py b/build/android/pylib/utils/findbugs.py
index 3ad2c5a196b4a152a2d59ff7335193289de9028b..995801a6a16d4d19714610508967f74c1c8709c6 100755
--- a/build/android/pylib/utils/findbugs.py
+++ b/build/android/pylib/utils/findbugs.py
@@ -11,6 +11,7 @@ import shlex
import subprocess
import sys
+from pylib import cmd_helper
from pylib import constants
@@ -73,10 +74,7 @@ def _GetChromeClasses(release_version):
version = 'Release'
path = os.path.join(constants.CHROME_DIR, 'out', version)
cmd = 'find %s -name "*.class"' % path
- proc = subprocess.Popen(shlex.split(cmd),
- stdout=subprocess.PIPE, stderr=subprocess.PIPE)
- out, err = proc.communicate()
-
+ out = cmd_helper.GetCmdOutput(shlex.split(cmd))
if not out:
print 'No classes found in %s' % path
return out
« no previous file with comments | « build/android/pylib/cmd_helper.py ('k') | build/android/pylib/utils/flakiness_dashboard_results_uploader.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698