[Android] Switch all subprocess.Popen calls to use a temporary file instead of PIPE.

build/android/pylib/android_commands.py

Index: build/android/pylib/android_commands.py
diff --git a/build/android/pylib/android_commands.py b/build/android/pylib/android_commands.py
index e565ec89493d6f23449b2b47171377c26e17bb4e..f370efee13d67f7df8d7366a760f6f29662ed1d9 100644
--- a/build/android/pylib/android_commands.py
+++ b/build/android/pylib/android_commands.py
@@ -204,6 +204,7 @@ class AndroidCommands(object):
     self._device = device
     self._logcat = None
     self.logcat_process = None
+    self._logcat_tmpoutfile = None
     self._pushed_files = []
     self._device_utc_offset = self.RunShellCommand('date +%z')[0]
     self._md5sum_path = ''
@@ -955,8 +956,9 @@ class AndroidCommands(object):
       self._adb.SendCommand('logcat -c')
     logcat_command = 'adb %s logcat -v threadtime %s' % (self._adb._target_arg,

[Isaac (away), 2013/04/09 20:53:54]

yikes -- why is this a shell command?

[craigdh, 2013/04/09 21:25:00]

We need to go through and remove most of the shell=True, but that needs to wait
for another cl.

                                                          ' '.join(filters))
+    self._logcat_tmpoutfile = tempfile.TemporaryFile(bufsize=0)
     self.logcat_process = subprocess.Popen(logcat_command, shell=True,
-                                           stdout=subprocess.PIPE)
+                                           stdout=self._logcat_tmpoutfile)
 
   def StopRecordingLogcat(self):
     """Stops an existing logcat recording subprocess and returns output.
@@ -972,8 +974,11 @@ class AndroidCommands(object):
     # Otherwise the communicate may return incomplete output due to pipe break.
     if self.logcat_process.poll() is None:
       self.logcat_process.kill()
-    (output, _) = self.logcat_process.communicate()
+    self.logcat_process.wait()
     self.logcat_process = None
+    self._logcat_tmpoutfile.seek(0)
+    output = self._logcat_tmpoutfile.read()
+    self._logcat_tmpoutfile.close()
     return output
 
   def SearchLogcatRecord(self, record, message, thread_id=None, proc_id=None,