[Android] Switch all subprocess.Popen calls to use a temporary file instead of PIPE.

build/android/pylib/utils/flakiness_dashboard_results_uploader.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Uploads the results to the flakiness dashboard server."""
 
 import logging
 import os
 import shutil
 import subprocess
@@ skipping 12 matching lines @@
 sys.path.append(
     os.path.abspath(os.path.join(os.path.dirname(__file__),
                                  os.pardir, os.pardir, os.pardir, os.pardir,
                                  os.pardir, os.pardir, os.pardir,
                                  'Tools', 'Scripts')))
 
 from webkitpy.common.system import executive, filesystem
 from webkitpy.layout_tests.layout_package import json_results_generator
 
 #TODO(craigdh): pylib/utils/ should not depend on pylib/.
+from pylib import cmd_helper
 from pylib import constants
 
 
 # The JSONResultsGenerator gets the filesystem.join operation from the Port
 # object. Creating a Port object requires specifying information that only
 # makes sense for running WebKit layout tests, so we provide a dummy object
 # that contains the fields required by the generator.
 class PortDummy(object):
   def __init__(self):
     self._executive = executive.Executive()
@@ skipping 47 matching lines @@
         return False
       return _is_git_directory(parent)
 
     def _get_git_revision(in_directory):
       """Returns the git hash tag for the given directory.
 
       Args:
         in_directory: The directory where git is to be run.
       """
       command_line = ['git', 'log', '-1', '--pretty=format:%H']
-      output = subprocess.Popen(command_line,
-                                cwd=in_directory,
-                                stdout=subprocess.PIPE).communicate()[0]
+      output = cmd_helper.GetCmdOutput(command_line, cwd=in_directory)
       return output[0:40]
 
     in_directory = os.path.join(constants.CHROME_DIR, in_directory)
 
     if not os.path.exists(os.path.join(in_directory, '.svn')):
       if _is_git_directory(in_directory):
         return _get_git_revision(in_directory)
       else:
         return ''
 
-    # Note: Not thread safe: http://bugs.python.org/issue2320
-    output = subprocess.Popen(['svn', 'info', '--xml'],
-                              cwd=in_directory,
-                              stdout=subprocess.PIPE).communicate()[0]
+    output = cmd_helper.GetCmdOutput(['svn', 'info', '--xml'], cwd=in_directory)
     try:
       dom = xml.dom.minidom.parseString(output)
       return dom.getElementsByTagName('entry')[0].getAttribute('revision')
     except xml.parsers.expat.ExpatError:
       return ''
     return ''
 
 
 class ResultsUploader(object):
   """Handles uploading buildbot tests results to the flakiness dashboard."""
@@ skipping 83 matching lines @@
   """Reports test results to the flakiness dashboard for Chrome for Android.
 
   Args:
     results: test results.
     flakiness_dashboard_server: the server to upload the results to.
     test_type: the type of the tests (as displayed by the flakiness dashboard).
   """
   uploader = ResultsUploader(test_type)
   uploader.AddResults(results)
   uploader.Upload(flakiness_dashboard_server)