Issue 13861005: Delay HttpClientResponse until HttpClientRequest is fully sent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13861005: Delay HttpClientResponse until HttpClientRequest is fully sent. (Closed)

Created:
7 years, 8 months ago by Anders Johnsen

Modified:
7 years, 8 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Delay HttpClientResponse until HttpClientRequest is fully sent. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21144

Patch Set 2 : Remove test. #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -126 lines)			Patch
M	sdk/lib/io/http_impl.dart	View		3 chunks	+52 lines, -41 lines	0 comments	Download
M	tests/standalone/io/http_client_request_test.dart	View		1 chunk	+5 lines, -3 lines	0 comments	Download
M	tests/standalone/io/http_close_test.dart	View		2 chunks	+0 lines, -42 lines	0 comments	Download
M	tests/standalone/io/regress_6521_test.dart	View	1	1 chunk	+0 lines, -40 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/13861005/diff/1/tests/standalone/io/regress_6521_test.dart File tests/standalone/io/regress_6521_test.dart (right): https://codereview.chromium.org/13861005/diff/1/tests/standalone/io/regress_6521_test.dart#newcode7 tests/standalone/io/regress_6521_test.dart:7: import "dart:async"; Maybe just remove this test.

7 years, 8 months ago (2013-04-09 10:44:35 UTC) #2

Anders Johnsen

Landing. https://codereview.chromium.org/13861005/diff/1/tests/standalone/io/regress_6521_test.dart File tests/standalone/io/regress_6521_test.dart (right): https://codereview.chromium.org/13861005/diff/1/tests/standalone/io/regress_6521_test.dart#newcode7 tests/standalone/io/regress_6521_test.dart:7: import "dart:async"; On 2013/04/09 10:44:35, Søren Gjesse wrote: ...

7 years, 8 months ago (2013-04-09 10:48:42 UTC) #3

Anders Johnsen

7 years, 8 months ago (2013-04-09 10:49:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21144 (presubmit successful).

Expand Messages | Collapse Messages

Issue 13861005: Delay HttpClientResponse until HttpClientRequest is fully sent. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Remove test. #

Messages