chrome/browser/android/chrome_jni_registrar.cc - Issue 1386043002: Open distiller UI setting through JavaScript

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/chrome_jni_registrar.cc

Issue 1386043002: Open distiller UI setting through JavaScript (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment nits Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/chrome_jni_registrar.cc

diff --git a/chrome/browser/android/chrome_jni_registrar.cc b/chrome/browser/android/chrome_jni_registrar.cc

index 210bbd99fabd330eabb434ac5c66c9be033d1a72..15b400d52ae4207ac956a42d89259fd27aebd255 100644

--- a/chrome/browser/android/chrome_jni_registrar.cc

+++ b/chrome/browser/android/chrome_jni_registrar.cc

@@ -32,7 +32,7 @@

#include "chrome/browser/android/cookies/cookies_fetcher.h"

#include "chrome/browser/android/dev_tools_server.h"

#include "chrome/browser/android/document/document_web_contents_delegate.h"

-#include "chrome/browser/android/dom_distiller/external_feedback_reporter_android.h"

+#include "chrome/browser/android/dom_distiller/distiller_ui_handle_android.h"

#include "chrome/browser/android/download/chrome_download_delegate.h"

#include "chrome/browser/android/favicon_helper.h"

#include "chrome/browser/android/feature_utilities.h"

@@ -245,7 +245,7 @@ static base::android::RegistrationMethod kChromeRegisteredMethods[] = {

RegisterExternalPrerenderHandlerAndroid},

{"FaviconHelper", FaviconHelper::RegisterFaviconHelper},

{"FeatureUtilities", RegisterFeatureUtilities},

- {"FeedbackReporter", dom_distiller::android::RegisterFeedbackReporter},

+ {"DomDistillerUIUtils", dom_distiller::android::RegisterUIHandle},

{"FindInPageBridge", FindInPageBridge::RegisterFindInPageBridge},

{"FontSizePrefsAndroid", FontSizePrefsAndroid::Register},

{"ForeignSessionHelper",