Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1386023003: Add full BoringSSL error information to Dart exceptions it throws. (Closed)

Created:
5 years, 2 months ago by Bill Hesse
Modified:
5 years, 2 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add full BoringSSL error information to Dart exceptions it throws. Fix error in http_proxy_advanced_test. BUG=https://github.com/dart-lang/sdk/issues/24183 BUG=https://github.com/dart-lang/sdk/issues/24068 BUG=https://github.com/dart-lang/sdk/issues/24074 R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/da574129a8256d0b480035f73dd7a1d078bf22b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -16 lines) Patch
M runtime/bin/secure_socket.cc View 1 chunk +20 lines, -7 lines 0 comments Download
M tests/standalone/io/http_proxy_advanced_test.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M tests/standalone/io/http_proxy_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Bill Hesse
5 years, 2 months ago (2015-10-06 13:49:43 UTC) #2
Søren Gjesse
lgtm
5 years, 2 months ago (2015-10-06 13:57:04 UTC) #3
Bill Hesse
5 years, 2 months ago (2015-10-06 14:30:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
da574129a8256d0b480035f73dd7a1d078bf22b1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698