pkg/analyzer/lib/src/context/context.dart - Issue 1386023002: Resolve ordering issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/context/context.dart

Issue 1386023002: Resolve ordering issues. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/status/get_handler.dart ('k') | pkg/analyzer/lib/src/generated/element.dart » ('j') | pkg/analyzer/lib/src/task/dart.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analyzer/lib/src/context/context.dart

diff --git a/pkg/analyzer/lib/src/context/context.dart b/pkg/analyzer/lib/src/context/context.dart

index 0d1067da738713e13dd340e196cab27db9c8cf27..9a9c7fad078bda4b2bccf42800b933e8fe5c0e82 100644

--- a/pkg/analyzer/lib/src/context/context.dart

+++ b/pkg/analyzer/lib/src/context/context.dart

@@ -1139,10 +1139,8 @@ class AnalysisContextImpl implements InternalAnalysisContext {

entry = getCacheEntry(unit);

setValue(HINTS, AnalysisError.NO_ERRORS);

// dartEntry.setValue(LINTS, AnalysisError.NO_ERRORS);

- setValue(INFER_STATIC_VARIABLE_TYPES_ERRORS, AnalysisError.NO_ERRORS);

setValue(LIBRARY_UNIT_ERRORS, AnalysisError.NO_ERRORS);

- setValue(PARTIALLY_RESOLVE_REFERENCES_ERRORS, AnalysisError.NO_ERRORS);

- setValue(RESOLVE_FUNCTION_BODIES_ERRORS, AnalysisError.NO_ERRORS);

+ setValue(RESOLVE_UNIT_ERRORS, AnalysisError.NO_ERRORS);

setValue(RESOLVE_TYPE_NAMES_ERRORS, AnalysisError.NO_ERRORS);

entry.setState(RESOLVED_UNIT, CacheState.FLUSHED);

entry.setState(RESOLVED_UNIT1, CacheState.FLUSHED);

@@ -1153,6 +1151,7 @@ class AnalysisContextImpl implements InternalAnalysisContext {

entry.setState(RESOLVED_UNIT6, CacheState.FLUSHED);

entry.setState(RESOLVED_UNIT7, CacheState.FLUSHED);

entry.setState(RESOLVED_UNIT8, CacheState.FLUSHED);

+ entry.setState(RESOLVED_UNIT9, CacheState.FLUSHED);

// USED_IMPORTED_ELEMENTS

// USED_LOCAL_ELEMENTS

setValue(VARIABLE_REFERENCE_ERRORS, AnalysisError.NO_ERRORS);

@@ -1228,8 +1227,9 @@ class AnalysisContextImpl implements InternalAnalysisContext {

entry.setState(RESOLVED_UNIT4, CacheState.FLUSHED);

entry.setState(RESOLVED_UNIT5, CacheState.FLUSHED);

entry.setState(RESOLVED_UNIT6, CacheState.FLUSHED);

- entry.setState(RESOLVED_UNIT5, CacheState.FLUSHED);

Leaf 2015/10/06 00:14:58 I think this was a bug?

Brian Wilkerson 2015/10/06 19:04:46 Yes, i'm sure it was a bug.

+ entry.setState(RESOLVED_UNIT7, CacheState.FLUSHED);

entry.setState(RESOLVED_UNIT8, CacheState.FLUSHED);

+ entry.setState(RESOLVED_UNIT9, CacheState.FLUSHED);

entry.setState(RESOLVED_UNIT, CacheState.FLUSHED);

}

« no previous file with comments | « pkg/analysis_server/lib/src/status/get_handler.dart ('k') | pkg/analyzer/lib/src/generated/element.dart » ('j') | pkg/analyzer/lib/src/task/dart.dart » ('J')