Issue 13860011: Fixing numerical rounding edge case in SkTileGrid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13860011: Fixing numerical rounding edge case in SkTileGrid (Closed)

Created:
7 years, 8 months ago by Justin Novosad

Modified:
7 years, 8 months ago

Reviewers:
Tom Hudson

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fixing numerical rounding edge case in SkTileGrid BUG=https://code.google.com/p/chromium/issues/detail?id=234688 TEST=TileGrid skia unit test Committed: https://code.google.com/p/skia/source/detail?r=8839

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -2 lines)			Patch
	M	src/core/SkTileGrid.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	tests/TileGridTest.cpp	View		2 chunks	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/junov@chromium.org/13860011/1

7 years, 8 months ago (2013-04-24 07:41:40 UTC) #3

Justin Novosad

7 years, 8 months ago (2013-04-24 15:39:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r8839 (presubmit successful).

Expand Messages | Collapse Messages