Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 13860006: Fix static type errors in a number of tests (Closed)

Created:
7 years, 8 months ago by Søren Gjesse
Modified:
7 years, 8 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix static type errors in a number of tests R=ager@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=21919

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -51 lines) Patch
M sdk/lib/io/http.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/standalone/float_array_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/io/echo_server_stream_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/file_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/standalone/io/http_auth_test.dart View 2 chunks +18 lines, -18 lines 0 comments Download
A tests/standalone/io/raw_secure_server_socket_argument_test.dart View 1 chunk +36 lines, -0 lines 0 comments Download
M tests/standalone/io/raw_secure_server_socket_test.dart View 3 chunks +1 line, -11 lines 0 comments Download
M tests/standalone/io/raw_server_socket_cancel_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/secure_server_socket_test.dart View 2 chunks +0 lines, -10 lines 0 comments Download
M tests/standalone/io/secure_socket_argument_test.dart View 1 chunk +15 lines, -1 line 0 comments Download
M tests/standalone/io/socket_close_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/socket_exception_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/socket_many_connections_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/web_socket_test.dart View 3 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
7 years, 8 months ago (2013-04-23 15:06:17 UTC) #1
Mads Ager (google)
LGTM!
7 years, 8 months ago (2013-04-23 15:07:59 UTC) #2
Søren Gjesse
7 years, 8 months ago (2013-04-24 06:12:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21919 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698