Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1385983002: Remove JavaScript.h (Closed)

Created:
5 years, 2 months ago by Tom Sepez
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove JavaScript.h It merely includes a bunch of other .h files which are handled better since we fixed IWYU. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/5e8b7356d68e35d7d631a2a917e651a4e7c73b65

Patch Set 1 #

Patch Set 2 : small comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -48 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/include/javascript/Field.h View 1 1 chunk +1 line, -1 line 0 comments Download
D fpdfsdk/include/javascript/JavaScript.h View 1 chunk +0 lines, -24 lines 0 comments Download
M fpdfsdk/include/javascript/color.h View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/Consts.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/javascript/Field.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/javascript/Icon.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Context.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_EventHandler.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_GlobalData.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Object.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Value.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/javascript/app.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/javascript/color.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/console.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/javascript/event.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/global.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/javascript/report.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/javascript/util.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M pdfium.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, quick review.
5 years, 2 months ago (2015-10-05 21:38:41 UTC) #2
Lei Zhang
lgtm
5 years, 2 months ago (2015-10-05 23:10:24 UTC) #3
Tom Sepez
5 years, 2 months ago (2015-10-05 23:18:35 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
5e8b7356d68e35d7d631a2a917e651a4e7c73b65 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698