Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 1385933002: clearly mark resource as deprecated (Closed)

Created:
5 years, 2 months ago by sethladd
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update changelog #

Patch Set 3 : indicate this is the last release #

Total comments: 2

Patch Set 4 : link to replacement #

Patch Set 5 : addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M CHANGELOG.md View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/core/resource.dart View 1 2 3 4 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
sethladd
Not ready to commit yet. I want to link to the pub package for the ...
5 years, 2 months ago (2015-10-05 17:22:10 UTC) #2
floitsch
LGTM.
5 years, 2 months ago (2015-10-05 17:36:54 UTC) #3
Lasse Reichstein Nielsen
I'm working on package:resource, it should be out in time for the actual 1.13 release ...
5 years, 2 months ago (2015-10-06 07:39:16 UTC) #4
sethladd
Thanks! Addressed the comments.
5 years, 2 months ago (2015-10-06 16:07:12 UTC) #5
sethladd
5 years, 2 months ago (2015-10-06 16:08:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
7b18bc7e141d548c3d8a5d4758e77b923f334e0c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698